Thomas,<br> I'll work on making the changes a little later. I'm in the middle of a test build for some changes that I'm making in other areas.<br><br>Martin<br><br><div class="gmail_quote">On Tue, Sep 14, 2010 at 12:54 PM, Thomas Petazzoni <span dir="ltr"><<a href="mailto:thomas.petazzoni@free-electrons.com">thomas.petazzoni@free-electrons.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Hello Martin,<br>
<br>
Thanks for your patchset !<br>
<br>
On Mon, 13 Sep 2010 20:40:47 -0700<br>
Martin Banky <<a href="mailto:martin.banky@gmail.com">martin.banky@gmail.com</a>> wrote:<br>
<br>
> +BISON_DIR:=$(BUILD_DIR)/bison-$(BISON_VERSION)<br>
<br>
This is not needed and shouldn't be there.<br>
<br>
> define BISON_DISABLE_EXAMPLES<br>
> echo 'all install:' > $(@D)/examples/Makefile<br>
> endef<br>
><br>
> +define BISON_NO_WCHAR_SUPPORT<br>
> + toolchain/patch-kernel.sh $(BISON_DIR) package/bison/bison-no-wchar/ \*.patch<br>
> +endef<br>
> +<br>
> +ifneq ($(BR2_USE_WCHAR),y)<br>
> +BISON_POST_CONFIGURE_HOOKS += BISON_NO_WCHAR_SUPPORT<br>
> +endif<br>
<br>
Personally, I'd prefer not to have patches applied conditionally. It's<br>
the patch itself that should do the right thing depending on whether<br>
wchar support is available or not, so that the patch can eventually be<br>
sent to the upstream project.<br>
<br>
Thanks!<br>
<br>
Thomas<br>
--<br>
<font color="#888888">Thomas Petazzoni, Free Electrons<br>
Kernel, drivers, real-time and embedded Linux<br>
development, consulting, training and support.<br>
<a href="http://free-electrons.com" target="_blank">http://free-electrons.com</a><br>
_______________________________________________<br>
buildroot mailing list<br>
<a href="mailto:buildroot@busybox.net">buildroot@busybox.net</a><br>
<a href="http://lists.busybox.net/mailman/listinfo/buildroot" target="_blank">http://lists.busybox.net/mailman/listinfo/buildroot</a><br>
</font></blockquote></div><br>