[Buildroot] [PATCH 2/2] package/smcroute: cross check PID with process name in stop action

Joachim Wiberg troglobit at gmail.com
Tue Sep 28 09:43:23 UTC 2021


Signed-off-by: Joachim Wiberg <troglobit at gmail.com>
---
 package/smcroute/S41smcroute | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/package/smcroute/S41smcroute b/package/smcroute/S41smcroute
index bdc0f87645..3bef3bcd85 100755
--- a/package/smcroute/S41smcroute
+++ b/package/smcroute/S41smcroute
@@ -4,12 +4,11 @@ NAME="smcroute"
 DAEMON="smcrouted"
 PIDFILE="/var/run/$NAME.pid"
 
-# shellcheck source=/dev/null
 [ -r "/etc/default/$NAME" ] && . "/etc/default/$NAME"
 
 cmd()
 {
-    start-stop-daemon -q -p "$PIDFILE" "$@"
+    start-stop-daemon -q -p "$PIDFILE" -x "/usr/sbin/$DAEMON" "$@"
     status=$?
     if [ $status -eq 0 ]; then
 	echo "OK"
@@ -22,8 +21,7 @@ cmd()
 case "$1" in
     start)
 	printf 'Starting %s: ' "$DAEMON"
-	# shellcheck disable=SC2086 # we need the word splitting
-	cmd -S -x "/usr/sbin/$DAEMON" -- $SMCROUTED_ARGS
+	cmd -S -- $SMCROUTED_ARGS
 	;;
 
     stop)
-- 
2.25.1



More information about the buildroot mailing list