[Buildroot] [PATCH v2, 1/2] package/lvm2: make a standard install for host

[Arnout Vandecappelle]

On 25/09/2021 09:49, Fabrice Fontaine wrote:
> Make a standard install (i.e. with pvcreate) for host as it is needed
> for libvirt

  I don't fully understand this. Does it mean:

Use the standard install for the host, so e.g. pvcreate is installed as well.
pvcreate is needed for libvirt.

> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
> ---
> Changes v1 -> v2 (after review of Yann E. Morin):
>   - Use --with-confdir instead of DESTDIR
> 
>   package/lvm2/lvm2.mk | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk
> index 3a94aebfd4..5ca0dc565f 100644
> --- a/package/lvm2/lvm2.mk
> +++ b/package/lvm2/lvm2.mk
> @@ -71,9 +71,9 @@ HOST_LVM2_CONF_OPTS = \
>   	--disable-dmeventd \
>   	--disable-fsadm \
>   	--disable-readline \
> -	--disable-selinux
> -HOST_LVM2_MAKE_OPTS = device-mapper
> -HOST_LVM2_INSTALL_OPTS = install_device-mapper
> +	--disable-selinux \
> +	--with-confdir=$(HOST_DIR)/etc
> +HOST_LVM2_INSTALL_OPTS = install

  This is the default, right? So this line can simply be removed?

  Regards,
  Arnout

>   
>   $(eval $(autotools-package))
>   $(eval $(host-autotools-package))
>