[Buildroot] [PATCH 1/2] package/lvm2: make a standard install for host

[Yann E. MORIN]

Fabrice, All,

On 2021-09-24 23:39 +0200, Fabrice Fontaine spake thusly:
> Make a standard install (i.e. with pvcreate) for host as it is needed
> for libvirt
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
> ---
>  package/lvm2/lvm2.mk | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk
> index 3a94aebfd4..d918b5f5b6 100644
> --- a/package/lvm2/lvm2.mk
> +++ b/package/lvm2/lvm2.mk
> @@ -72,8 +72,7 @@ HOST_LVM2_CONF_OPTS = \
>  	--disable-fsadm \
>  	--disable-readline \
>  	--disable-selinux
> -HOST_LVM2_MAKE_OPTS = device-mapper
> -HOST_LVM2_INSTALL_OPTS = install_device-mapper
> +HOST_LVM2_INSTALL_OPTS = DESTDIR=$(HOST_DIR) install

DESTDIR must not be used for host variants.

Indeed, they are already configured with --prefix=$(HOST_DIR) :
    https://git.buildroot.org/buildroot/tree/package/pkg-autotools.mk#n223

And DESTDIR is for out-of-tree installation, but for host packages we do
not install out-of-tree as their prefix is already correct.
    https://www.gnu.org/software/automake/manual/automake.html#DESTDIR

If the install fails because of things installed in /etc and such, then
appropriate --sysconfdir=$(HOST_DIR)/etc et al. should be specified
instead. Or maybe we only need 'make install-exec' ?

Regards,
Yann E. MORIN.

>  $(eval $(autotools-package))
>  $(eval $(host-autotools-package))
> -- 
> 2.33.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'