[Buildroot] [PATCH v2 1/2] package/alsa-lib: add smixer-python module for alsa-lib python config

Arnout Vandecappelle arnout at mind.be
Tue Sep 21 19:04:04 UTC 2021



On 09/09/2021 17:17, Illia Bitkov wrote:
> Add simple mixer python bindings to build when "Python support for alsa-lib" is active.
> smixer-python is the only one python module which exists in alsa-lib.

  Please wrap the commit message at 72 columns.

  I've changed the subject line to "package/alsa-lib: smixer-python module 
supports python3" because IMHO adding python3 is the most important feature of 
this patch.


  Applied to master, thanks.

  Regards,
  Arnout


> 
> Signed-off-by: Illia Bitkov <illia.bitkov at mind.be>
> ---
>   package/alsa-lib/Config.in   |  2 +-
>   package/alsa-lib/alsa-lib.mk | 10 ++++++++++
>   2 files changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/package/alsa-lib/Config.in b/package/alsa-lib/Config.in
> index f334b66bff..4168d1f220 100644
> --- a/package/alsa-lib/Config.in
> +++ b/package/alsa-lib/Config.in
> @@ -22,7 +22,7 @@ if BR2_PACKAGE_ALSA_LIB
>   
>   config BR2_PACKAGE_ALSA_LIB_PYTHON
>   	bool "Python support for alsa-lib"
> -	depends on BR2_PACKAGE_PYTHON
> +	depends on BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3
>   	help
>   	  Add python support for alsa-lib.
>   	  Python will be built and libpython will be installed
> diff --git a/package/alsa-lib/alsa-lib.mk b/package/alsa-lib/alsa-lib.mk
> index c71ad5dd58..99c53f9408 100644
> --- a/package/alsa-lib/alsa-lib.mk
> +++ b/package/alsa-lib/alsa-lib.mk
> @@ -57,12 +57,22 @@ ALSA_LIB_CONF_OPTS += --disable-old-symbols
>   endif
>   
>   ifeq ($(BR2_PACKAGE_ALSA_LIB_PYTHON),y)
> +ALSA_LIB_CONF_OPTS += \
> +	--enable-mixer-pymods
> +ifeq ($(BR2_PACKAGE_PYTHON),y)
>   ALSA_LIB_CONF_OPTS += \
>   	--with-pythonlibs=-lpython$(PYTHON_VERSION_MAJOR) \
>   	--with-pythonincludes=$(STAGING_DIR)/usr/include/python$(PYTHON_VERSION_MAJOR)
>   ALSA_LIB_CFLAGS += -I$(STAGING_DIR)/usr/include/python$(PYTHON_VERSION_MAJOR)
>   ALSA_LIB_DEPENDENCIES = python
>   else
> +ALSA_LIB_CONF_OPTS += \
> +	--with-pythonlibs=-lpython$(PYTHON3_VERSION_MAJOR) \
> +	--with-pythonincludes=$(STAGING_DIR)/usr/include/python$(PYTHON3_VERSION_MAJOR)
> +ALSA_LIB_CFLAGS += -I$(STAGING_DIR)/usr/include/python$(PYTHON3_VERSION_MAJOR)
> +ALSA_LIB_DEPENDENCIES = python3
> +endif
> +else
>   ALSA_LIB_CONF_OPTS += --disable-python
>   endif
>   
> 


More information about the buildroot mailing list