[Buildroot] Harfbuzz bump major version question

[Giulio Benetti]

On 9/20/21 11:00 AM, Arnout Vandecappelle wrote:
> 
> 
> On 20/09/2021 08:41, Thomas Petazzoni wrote:
>> Hello Giulio,
>>
>> On Sun, 19 Sep 2021 23:10:23 +0200
>> Giulio Benetti <giulio.benetti at benettiengineering.com> wrote:
>>
>>> I'm going to bump harfbuzz to version 3.0.0 but being a major version it
>>> looses 15 apis[1] and introduce some new ones. So I'm not that sure if
>>> this can be a normal bump or I need to introduce the new package
>>> harfbuzz3. Package pango that requires harfbuzz builds fine, but how
>>> should I proceed? Should I build every package that depends on it and
>>> check if it builds fine? Or should I add package harfbuzz3 and then
>>> every package that depends on harfbuzz should move to harfbuzz3 package
>>> per package? I'm new to this case so help is appreciated.
>>
>> The best is to not have to introduce a separate harfbuzz3 package, as
>> it really complicates things.
>>
>> There are not that many packages that have a dependency on harfbuzz:
>>
>> package/efl/efl.mk:ifeq ($(BR2_PACKAGE_HARFBUZZ),y)
>> package/libass/Config.in:       select BR2_PACKAGE_HARFBUZZ
>> package/mupdf/Config.in:        select BR2_PACKAGE_HARFBUZZ
>> package/pango/Config.in:        select BR2_PACKAGE_HARFBUZZ
>> package/qt5/qt5base/Config.in:config BR2_PACKAGE_QT5BASE_HARFBUZZ
>> package/qt5/qt5base/Config.in:  select BR2_PACKAGE_HARFBUZZ if \
>> package/qt5/qt5base/qt5base.mk:ifeq ($(BR2_PACKAGE_QT5BASE_HARFBUZZ),y)
>> package/supertuxkart/Config.in: select BR2_PACKAGE_HARFBUZZ
>> package/vlc/vlc.mk:ifeq ($(BR2_PACKAGE_HARFBUZZ),y)
>> package/webkitgtk/Config.in:    select BR2_PACKAGE_HARFBUZZ
>> package/wpewebkit/Config.in:    select BR2_PACKAGE_HARFBUZZ
>>
>> So I would suggest to create a configuration that builds all those
>> packages successfully prior to the harfbuzz bump, and then retry this
>> configuration with the harfbuzz bump applied. This will give you a
>> sense of how much breakage the API changes are causing.
> 
>    It would be nice to convert the explanation above into a documentation update!

I could add 'Updating a package' under 'III. Developer guide' in the 
manual on the same level of 'Adding new packages to Buildroot', does it 
sound good?

I've never contributed to the manual.

Best regards
-- 
Giulio Benetti
Benetti Engineering sas

>    Regards,
>    Arnout
> 
> _______________________________________________
> buildroot mailing list
> buildroot at lists.buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
>