[Buildroot] [PATCH v2, 1/1] package/uboot-tools: fix MKIMAGE_ARCH handling

[Fabrice Fontaine]

Le sam. 11 sept. 2021 à 18:16, Yann E. MORIN <yann.morin.1998 at free.fr> a écrit :
>
> Fabrice, All,
>
> On 2021-09-11 18:07 +0200, Fabrice Fontaine spake thusly:
> > Le sam. 11 sept. 2021 à 14:55, Yann E. MORIN <yann.morin.1998 at free.fr> a écrit :
> > > On 2021-09-08 18:45 +0200, Fabrice Fontaine spake thusly:
> > > > Fix MKIMAGE_ARCH handling to avoid the following build failure:
> [--SNIP--]
> > > > -ifeq ($(KERNEL_ARCH),x86_64)
> > > > -MKIMAGE_ARCH = x86
> > > > -else ifeq ($(KERNEL_ARCH),i386)
> > > > +# For i386, we need to convert
> > > > +# For openrisc, we need to convert
> > > > +# For others, we'll just keep KERNEL_ARCH
> > > > +ifeq ($(KERNEL_ARCH),i386)
> > > >  MKIMAGE_ARCH = x86
> > >
> > > But then, x86_64 should still be changed to x86, no?
> > Nope, x86_64 is recognized as a valid architecture, here is an extract
> > of the commit message:
> >
> >         x86              Intel x86
> >         x86_64           AMD x86_64
> >         xtensa           Xtensa
>
> Ah, right, I overlooked that in the list.
>
> What got me confused was that you specially mention or1k, but not
> x86_64, which was also wrong, but we do not seem to have any build
> failure associated with that, do we?
True, there are no build failures on x86_64.

I'm wondering if those build failures are raised because of toolchain aliases.
Indeed, it seems that openrisc can be defined as a alias to or1k:
https://github.com/u-boot/u-boot/blob/bbcacdf4cd23f2e5deb9ef916096c956c955243d/tools/buildman/README#L196
https://github.com/u-boot/u-boot/blob/a94ab561e2f49a80d8579930e840b810ab1a1330/tools/buildman/bsettings.py#L88

But I didn't find the root cause of these build failures, perhaps the
toolchain-alias is overwritten?
So I gave up and thought that this patch was an acceptable long-term solution.
>
> Regards,
> Yann E. MORIN.
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
Best Regards,

Fabrice