[Buildroot] [PATCH 1/1] package/boost: fix fiber dependencies

Michael Nosthoff buildroot at heine.tech
Mon Sep 6 12:53:40 UTC 2021


Hi,

On 05.09.21 20:25, Fabrice Fontaine wrote:
> Commit d39d8f7cee9b4634e6f490020204f63fae419e8e forgot to update fiber
> dependencies resulting in the following build failure:
>
> WARNING: unmet direct dependencies detected for BR2_PACKAGE_BOOST_FILESYSTEM
>    Depends on [n]: BR2_PACKAGE_BOOST [=y] && BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS [=n]
>    Selected by [y]:
>    - BR2_PACKAGE_BOOST_FIBER [=y] && BR2_PACKAGE_BOOST [=y] && BR2_PACKAGE_BOOST_CONTEXT_ARCH_SUPPORTS [=y] && BR2_TOOLCHAIN_HAS_THREADS_NPTL [=y] && !BR2_MIPS_CPU_MIPS32 [=n] && !BR2_MIPS_CPU_MIPS64 [=n] && (BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS [=n] || BR2_TOOLCHAIN_GCC_AT_LEAST_6 [=y]) && !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 [=n]
>
> Fixes:
>   - http://autobuild.buildroot.org/results/40b8af6ce273ebd5fca56d6734f64dacd562efb1
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
> ---
>   package/boost/Config.in | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/package/boost/Config.in b/package/boost/Config.in
> index f6409769c6..536e5b8486 100644
> --- a/package/boost/Config.in
> +++ b/package/boost/Config.in
> @@ -149,8 +149,7 @@ config BR2_PACKAGE_BOOST_FIBER
>   	# mips support uses the "pause" instruction, only available
>   	# since mips32r2/mips64r2.
>   	depends on !BR2_MIPS_CPU_MIPS32 && !BR2_MIPS_CPU_MIPS64
> -	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS \
> -		|| BR2_TOOLCHAIN_GCC_AT_LEAST_6 # boost-context -> boost-thread
> +	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS # boost-filesystem
>   	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # boost-context
>   	select BR2_PACKAGE_BOOST_CONTEXT
>   	select BR2_PACKAGE_BOOST_FILESYSTEM
> @@ -160,8 +159,7 @@ config BR2_PACKAGE_BOOST_FIBER
>   
>   comment "boost-fiber needs a toolchain w/ NPTL"
>   	depends on BR2_PACKAGE_BOOST_CONTEXT_ARCH_SUPPORTS
> -	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS \
> -		|| BR2_TOOLCHAIN_GCC_AT_LEAST_6
> +	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS
>   	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
>   
>   comment "boost-fiber needs a toolchain not affected by GCC bug 64735"

whoopsie, I somehow missed that this was an OR dependency. Nice catch!

Reviewed-by: Michael Nosthoff <buildroot at heine.tech>

Regards,
Michael




More information about the buildroot mailing list