[Buildroot] [PATCH] package/gqrx: add missing reverse dependency for gnuradio

Giulio Benetti giulio.benetti at benettiengineering.com
Mon Oct 25 18:59:26 UTC 2021


On 10/25/21 8:54 PM, Arnout Vandecappelle wrote:
> 
> 
> On 11/10/2021 00:42, Giulio Benetti wrote:
>> gnuradio suffers from gcc bug 43744 but gqrx that depends on it doesn't
>> take into account the gcc bug. So let's add it as:
>> 'depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_43744 # gnuradio'
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti at benettiengineering.com>
>> ---
>>    package/gqrx/Config.in | 4 +++-
>>    1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/package/gqrx/Config.in b/package/gqrx/Config.in
>> index 60942c36c8..9faa50603e 100644
>> --- a/package/gqrx/Config.in
>> +++ b/package/gqrx/Config.in
>> @@ -8,7 +8,8 @@ comment "gqrx needs a toolchain w/ C++, threads, wchar, dynamic library"
>>    comment "gqrx needs qt5"
>>    	depends on !BR2_PACKAGE_QT5
>>    
>> -comment "gqrx needs a toolchain not affected by GCC bug 64735"
>> +comment "gqrx needs a toolchain not affected by GCC bug 43744 and 64735"
>> +	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_43744 # gnuradio
>>    	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735
> 
>    This should have been an or instead of an and.

Aah, yes, sorry and thank you for fixing

Best regards
-- 
Giulio Benetti
Benetti Engineering sas

>    Committed with that fixed, thanks.
> 
>    Regards,
>    Arnout
> 
>>    
>>    config BR2_PACKAGE_GQRX
>> @@ -21,6 +22,7 @@ config BR2_PACKAGE_GQRX
>>    	depends on BR2_TOOLCHAIN_HAS_SYNC_4 || BR2_TOOLCHAIN_HAS_ATOMIC
>>    	depends on BR2_PACKAGE_QT5
>>    	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS # gnuradio -> boost-atomic
>> +	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_43744 # gnuradio
>>    	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # gnuradio
>>    	select BR2_PACKAGE_BOOST
>>    	select BR2_PACKAGE_BOOST_PROGRAM_OPTIONS
>>
> _______________________________________________
> buildroot mailing list
> buildroot at buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
> 



More information about the buildroot mailing list