[Buildroot] [PATCH 2/2] treewide: fix flake8 error E741 ambiguous variable name

Peter Korsgaard peter at korsgaard.com
Mon Oct 25 12:12:22 UTC 2021


>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be> writes:

 > A recent update of flake8 in CI introduced a new check E741. It
 > basically checks that variables are at least 3 characters long. Up to
 > now, however, we have used shorter names in some places - all of them
 > turn out to be "l" for a line of text.

 > Replace all those "l" variables with "line".

 > Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/1687009829

NIT: This is not about requiring >= 3 char variables, it is specifically
about the variables I, O and l as they may look very similar to the
numbers 0/1, depending on the font:

https://www.flake8rules.com/rules/E741.html

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list