[Buildroot] [PATCH] package/opensc: add package
Arnout Vandecappelle
arnout at mind.be
Sun Oct 17 16:18:00 UTC 2021
Hi José,
Same comments on this patch as what Gilles gave on the softhsm2 one.
On 08/10/2021 13:03, José Pekkarinen wrote:
> The following patch will add a recipe to
> install opensc in final images.
>
> Signed-off-by: José Pekkarinen <jose.pekkarinen at unikie.com>
> ---
> package/opensc/Config.in | 7 +++++++
> package/opensc/opensc.mk | 15 +++++++++++++++
You need to add it to package/Config.in, you need to add a hash file, and
preferably also add yourself to DEVELOPERS for this package.
It's also convenient if you put the two packages together in a series, because
the DEVELOPERS and package/Config.in are likely to cause conflicts.
> 2 files changed, 22 insertions(+)
> create mode 100644 package/opensc/Config.in
> create mode 100644 package/opensc/opensc.mk
>
> diff --git a/package/opensc/Config.in b/package/opensc/Config.in
> new file mode 100644
> index 0000000000..abd26a9b08
> --- /dev/null
> +++ b/package/opensc/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_OPENSC
> + bool "opensc"
> + depends on BR2_PACKAGE_LIBOPENSSL && BR2_PACKAGE_PCSC_LITE
> + help
> + OpenSC provides a set of libraries and utilities to work with smart cards.
Indentation + wrapping. Please use utils/check-package to verify.
> +
> + https://github.com/OpenSC/OpenSC.git
The URL shouldn't have a .git part. That said, a better location is
https://github.com/OpenSC/OpenSC/wiki
> diff --git a/package/opensc/opensc.mk b/package/opensc/opensc.mk
> new file mode 100644
> index 0000000000..7741dac2a5
> --- /dev/null
> +++ b/package/opensc/opensc.mk
> @@ -0,0 +1,15 @@
> +################################################################################
> +#
> +# opensc
> +#
> +################################################################################
> +
> +OPENSC_VERSION = 0.22.0
> +OPENSC_SITE = $(call github,OpenSC,OpenSC,$(OPENSC_VERSION))
There's an uploaded tarball at
https://github.com/OpenSC/OpenSC/releases/download/0.22.0/opensc-0.22.0.tar.gz
> +OPENSC_LICENSE = GPL-2
I haven't checked in detail, but it seems to be LGPL-2.1+
> +OPENSC_LICENSE_FILES = LICENSE
This file doesn't even exist.
> +OPENSC_DEPENDENCIES = openssl pcsc-lite
> +OPENSC_AUTORECONF = YES
You need to add a comment why this is needed. It probably isn't with the
uploaded tarball.
> +OPENSC_INSTALL_TARGET = YES
This is unnecessary (default). _INSTALL_STAGING, on the other hand, *is*
necessary.
> +
> +$(eval $(autotools-package))
>
More information about the buildroot
mailing list