[Buildroot] [PATCH v4 2/2] package: add smpq

[Gleb Mazovetskiy]

The use case for me is to build DevilutionX (Diablo 1 source port) in a
gaming-oriented buildroot-based distro (batocera.linux).

DevilutionX produces an MPQ archive during the build process using smpq, so
smpq needs to be a host package.

I'm not near a computer for the next few days so I'd appreciate if you
could adjust the commit message and DEVELOPERS when merging.

Thanks, Gleb


On Sun, 17 Oct 2021, 04:37 Thomas Petazzoni, <thomas.petazzoni at bootlin.com>
wrote:

> Hello Gleb,
>
> On Mon, 11 Oct 2021 22:21:25 +0100
> Gleb Mazovetskiy <glex.spb at gmail.com> wrote:
>
> > smpq is a utility for manipulating Blizzard MPQ archives.
> >
> > smpq is a build-time dependency of several source ports /
> > reimplementations of Blizzard games, such as DevilutionX.
> >
> > Signed-off-by: Gleb Mazovetskiy <glex.spb at gmail.com>
>
> Thanks for this contribution. Could you clarify practical speaking in
> which context this library is useful?
>
> > --- /dev/null
> > +++ b/package/smpq/smpq.mk
> > @@ -0,0 +1,19 @@
> >
> +################################################################################
> > +#
> > +# smpq
> > +#
> >
> +################################################################################
> > +
> > +SMPQ_VERSION = 1.6
> > +SMPQ_SOURCE = smpq_$(SMPQ_VERSION).orig.tar.gz
> > +SMPQ_SITE = https://launchpad.net/smpq/trunk/$(SMPQ_VERSION)/+download
> > +SMPQ_LICENSE = GPL-3.0+
> > +SMPQ_LICENSE_FILES = LICENSE
> > +SMPQ_DEPENDENCIES = stormlib
> > +HOST_SMPQ_DEPENDENCIES = host-stormlib
> > +SMPQ_CONF_OPTS += -DWITH_KDE=OFF
> > +HOST_SMPQ_CONF_OPTS += -DWITH_KDE=OFF
> > +SMPQ_INSTALL_STAGING = YES
> > +
> > +$(eval $(cmake-package))
> > +$(eval $(host-cmake-package))
>
> Why do you need a host variant of this package? It isn't used by
> anything else. Could you clarify this?
>
> Note: for both of your package submissions, the commit title should be
> "package/<foo>: new package". And also, in each patch adding the
> packages, you need to add yourself in the DEVELOPERS file for this
> package.
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.buildroot.org/pipermail/buildroot/attachments/20211017/067f7cf0/attachment.html>