[Buildroot] [PATCH 1/1] package/wireguard-linux-compat: add missing comment about kernel dependency

Peter Korsgaard peter at korsgaard.com
Sat Oct 16 08:58:00 UTC 2021


>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice at gmail.com> writes:

 > Le sam. 16 oct. 2021 à 10:46, Peter Korsgaard <peter at korsgaard.com> a écrit :
 >> 
 >> >>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice at gmail.com> writes:
 >> 
 >> > Add a comment when kernel is not enabled (missing since the addition of
 >> > the package in commit de591c5c3a93a40d049a32bd79c30cc66daf5fb2)
 >> 
 >> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
 >> > ---
 >> >  package/wireguard-linux-compat/Config.in | 3 +++
 >> >  1 file changed, 3 insertions(+)
 >> 
 >> > diff --git a/package/wireguard-linux-compat/Config.in
 >> > b/package/wireguard-linux-compat/Config.in
 >> > index 5a323a35e5..4e8e95bdc3 100644
 >> > --- a/package/wireguard-linux-compat/Config.in
 >> > +++ b/package/wireguard-linux-compat/Config.in
 >> > @@ -21,6 +21,9 @@ config BR2_PACKAGE_WIREGUARD_LINUX_COMPAT
 >> 
 >> >        https://www.wireguard.com
 >> 
 >> > +comment "wireguard-linux-compat needs a Linux kernel to be built"
 >> > +    depends on !BR2_LINUX_KERNEL
 >> 
 >> Is this really a sensible comment? I would imagine that needing a Linux
 >> kernel is an obvious requirement for a kernel driver?
 > We have this comment for other drivers such as dahdi-linux and xr819-xradio.
 > So I think we should be consistent in all packages.

Ok, I'll take care of it.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list