[Buildroot] [PATCH 1/1] package/pkg-autotools: fix autoreconf with autoconf >= 2.70

[Arnout Vandecappelle]

On 12/10/2021 22:53, Arnout Vandecappelle wrote:
>
>
> On 06/10/2021 18:20, Fabrice Fontaine wrote:
>> The following build failure is raised since bump of autoconf to version
>> 2.71 in commit ecd54b65c1f998a7ccd91f7c523e4ff38c4781da and
>> http://git.savannah.gnu.org/gitweb/?p=autoconf.git;a=commit;h=dd880a0a6de5602cdd40b770ed6b083b34aa0768: 
>>
>>
>> Can't exec "gtkdocize": No such file or directory at 
>> /home/buildroot/autobuild/instance-1/output-1/host/share/autoconf/Autom4te/FileUtils.pm 
>> line 293.
>> autoreconf: error: gtkdocize failed with exit status: 2
>>
>> This failure is raised because autoreconf runs gtkdocize if configure.ac
>> contains GTK_DOC_CHECK, so set GTKDOCIZE to true in pkg-autotools to fix
>> this issue for all affected packages (i.e. host-libgtk3, libtasn1,
>> raptor, etc.). Indeed, gtk-doc is already forcefully disabled in
>> pkg-autotools through --disable-gtk-doc configure flag.
>>
>> Fixes:
>>   - 
>> http://autobuild.buildroot.org/results/ce974281acdd6729327f2083b24f62485f9b1e1a
>>   - 
>> http://autobuild.buildroot.org/results/23dd993be4dcd7937d48eef4521690bf30123979
>>   - 
>> http://autobuild.buildroot.org/results/bcf489ccd41197b57b39312b369921467f295431
>>
>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
>
>  I have instead applied [1], which puts it in AUTORECONF itself. I think 
> that's a more appropriate place since it also has AUTPOINT=/bin/true already.
>
>  Regards,
>  Arnout

[1] 
https://patchwork.ozlabs.org/project/buildroot/patch/VI1P190MB0493F6B7C3CA5E53F0A7B9049FB59@VI1P190MB0493.EURP190.PROD.OUTLOOK.COM/


>
>> ---
>>   package/pkg-autotools.mk | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/package/pkg-autotools.mk b/package/pkg-autotools.mk
>> index daa688dab6..7720d6ffe7 100644
>> --- a/package/pkg-autotools.mk
>> +++ b/package/pkg-autotools.mk
>> @@ -100,7 +100,7 @@ endef
>>   #
>>   define AUTORECONF_HOOK
>>       @$(call MESSAGE,"Autoreconfiguring")
>> -    $(Q)cd $($(PKG)_SRCDIR) && $($(PKG)_AUTORECONF_ENV) $(AUTORECONF) 
>> $($(PKG)_AUTORECONF_OPTS)
>> +    $(Q)cd $($(PKG)_SRCDIR) && GTKDOCIZE="true" $($(PKG)_AUTORECONF_ENV) 
>> $(AUTORECONF) $($(PKG)_AUTORECONF_OPTS)
>>   endef
>> ################################################################################
>>