[Buildroot] [PATCH 1/5] package/gdb: append to dependencies in conditional

Yann E. MORIN yann.morin.1998 at free.fr
Sun Oct 10 08:49:23 UTC 2021


Thomas, All,

On 2021-10-09 21:16 +0200, Thomas Petazzoni spake thusly:
> Repeat after me: "Forcing the value of <pkg>_DEPENDENCIES inside a
> conditional is the root of all evil."
> 
> Repeat after me: "Forcing the value of <pkg>_DEPENDENCIES inside a
> conditional is the root of all evil."
> 
> Repeat after me: "Forcing the value of <pkg>_DEPENDENCIES inside a
> conditional is the root of all evil."
> 
> Repeat after me: "Forcing the value of <pkg>_DEPENDENCIES inside a
> conditional is the root of all evil."

Forcing the value of <pkg>_DEPENDENCIES inside a conditional is the root
of all evil.

> Enough? :-)

I guess so, yes! Next time you send a patch that forces the value of
<pkg>_DEPENDENCIES in a conditional, I'll try not to apply it! ;-)

> Due to this mistake, any other GDB_DEPENDENCIES defined before this
> assignment were lost. For example, the host-flex host-bison added
> inside the GDB_FROM_GIT==y condition were ignored if
> BR2_PACKAGE_GDB_DEBUGGER.
> 
> Fixes the build of all ARC configurations that have
> BR2_PACKAGE_GDB_DEBUGGER enabled.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/gdb/gdb.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk
> index f9010019f5..4ead75289e 100644
> --- a/package/gdb/gdb.mk
> +++ b/package/gdb/gdb.mk
> @@ -147,7 +147,7 @@ ifeq ($(BR2_PACKAGE_GDB_DEBUGGER),y)
>  GDB_CONF_OPTS += \
>  	--enable-gdb \
>  	--with-curses
> -GDB_DEPENDENCIES = ncurses \
> +GDB_DEPENDENCIES += ncurses \
>  	$(if $(BR2_PACKAGE_LIBICONV),libiconv)
>  else
>  GDB_CONF_OPTS += \
> -- 
> 2.31.1
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'


More information about the buildroot mailing list