[Buildroot] [PATCH 1/1] package/webkitgtk: remove gst1-plugins-good from dependencies

Peter Korsgaard peter at korsgaard.com
Wed Oct 6 15:18:01 UTC 2021


>>>>> "Adrian" == Adrian Perez de Castro <aperez at igalia.com> writes:

 > This is only a runtime dependency, not a build dependency.
 > Based on a similar patch by James Hilliard for the wpewebkit
 > package.

 > Signed-off-by: Adrian Perez de Castro <aperez at igalia.com>
 > ---
 >  package/webkitgtk/webkitgtk.mk | 2 +-
 >  1 file changed, 1 insertion(+), 1 deletion(-)

 > diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk
 > index 6687d7f61b..87aeffea45 100644
 > --- a/package/webkitgtk/webkitgtk.mk
 > +++ b/package/webkitgtk/webkitgtk.mk
 > @@ -46,7 +46,7 @@ ifeq ($(BR2_PACKAGE_WEBKITGTK_MULTIMEDIA),y)
 >  WEBKITGTK_CONF_OPTS += \
 >  	-DENABLE_VIDEO=ON \
 >  	-DENABLE_WEB_AUDIO=ON
 > -WEBKITGTK_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base gst1-plugins-good
 > +WEBKITGTK_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base

NIT: we normally add a # runtime comment to the select line in Config.in
then to make it clear why it isn't listed in _DEPENDENCIES.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list