[Buildroot] [git commit] Revert "support/dependencies: don't check for `which'"
Yann E. MORIN
yann.morin.1998 at free.fr
Fri Oct 1 18:09:55 UTC 2021
commit: https://git.buildroot.net/buildroot/commit/?id=6cddc00399759296ab64fad4956380d89cd71609
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
This reverts commit a95c353a46247db036862ad839c095ca9ae4f690.
Switching to using 'command -v' instead of 'which', opened a can of
worms that is hard to fix in a timely manner:
- recursive call to 'make' from a post-build, post-iamge script, fails
because of a redefinition of HOSTCC_NOCCACHE (a bug on its own that
needs a separate fix anyway) [0];
- 'make' believeing it can call "simple" commands with execve() et al.
instead of passing them through a shell via system(), and thus
failing to find 'command' in the PATH [1].
[0] https://lore.kernel.org/buildroot/20211001175329.GA1973888@lbrmn-mmayer.ric.broadcom.net/T/#m95c17eb8374e4e3dd6eee700d397aa12cca0739e
[1] https://lore.kernel.org/buildroot/20211001180304.GV1504958@scaer/T/#m3a8f36bd76ec7d8e5038a6c8932bb6ffe23ea268
Signed-off-by: Yann E. MORIN <yann.morin.1998 at free.fr>
---
support/dependencies/dependencies.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/support/dependencies/dependencies.sh b/support/dependencies/dependencies.sh
index a3e0b3ecc4..c5dcb86231 100755
--- a/support/dependencies/dependencies.sh
+++ b/support/dependencies/dependencies.sh
@@ -65,6 +65,8 @@ check_prog_host()
fi
}
+# Verify that which is installed
+check_prog_host "which"
# Verify that sed is installed
check_prog_host "sed"
More information about the buildroot
mailing list