[Buildroot] [PATCH 1/2] support/docker: don't use sudo to build
Romain Naour
romain.naour at gmail.com
Tue Nov 23 21:40:17 UTC 2021
Hello Yann,
Le 23/11/2021 à 21:56, Yann E. MORIN a écrit :
> On a properly setup machine, it is totally useless to use sudo to run
> docker; it is very bad practice. Instead, users really should add
> themselves to the docker group.
>
> Signed-off-by: Yann E. MORIN <yann.morin.1998 at free.fr>
> Cc: Romain Naour <romain.naour at gmail.com>
> Cc: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
> ---
> support/docker/Dockerfile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/support/docker/Dockerfile b/support/docker/Dockerfile
> index 2aee129668..57445d5cd1 100644
> --- a/support/docker/Dockerfile
> +++ b/support/docker/Dockerfile
> @@ -1,7 +1,7 @@
> # This Dockerfile generates the docker image that gets used by Gitlab CI
> # To build it (YYYYMMDD.HHMM is the current date and time in UTC):
> -# sudo docker build -t buildroot/base:YYYYMMDD.HHMM support/docker
> -# sudo docker push buildroot/base:YYYYMMDD.HHMM
> +# docker build -t buildroot/base:YYYYMMDD.HHMM support/docker
> +# docker push buildroot/base:YYYYMMDD.HHMM
Reviewed-by: Romain Naour <romain.naour at gmail.com>
Best regards,
Romain
>
> # We use a specific tag for the base image *and* the corresponding date
> # for the repository., so do not forget to update the apt-sources.list
>
More information about the buildroot
mailing list