[Buildroot] [PATCH v2, 1/2] Revert "package/log4cxx: select boost chrono and date-time with gcc < 7"

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sun Nov 21 13:57:41 UTC 2021


On Fri, 19 Nov 2021 18:55:52 +0100
Fabrice Fontaine <fontaine.fabrice at gmail.com> wrote:

> This reverts commit 3c2245cb65741c965f4bb87d35ac3c64f250a1ae to move
> these selects on boost side as the build failure was raised with gcc >=
> 7 (making this commit a "no-op"). Indeed, the build failure is raised
> with cmake < 3.21.3, because cmake assumed that boost thread depends on
> date-time until
> https://github.com/Kitware/CMake/commit/1ad0c5ae53fc0c4f774166337f0e9c93c578cf9b.

I don't understand why you say this commit is a no-op. It clearly
isn't. In gcc < 7.x configurations, this commit ensures that boost
chrono and boost date-time are selected.

The fact that you realize later that the build failure occurred with
gcc >= 7.x, meaning this commit does not help fixing the issue does not
make this commit a no-op.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com


More information about the buildroot mailing list