[Buildroot] [PATCH 1/2] Revert "package/log4cxx: select boost chrono and date-time with gcc < 7"

[Fabrice Fontaine]

Hi Yann,

Le ven. 19 nov. 2021 à 18:10, Yann E. MORIN <yann.morin.1998 at free.fr> a écrit :
>
> Fabrice, All,
>
> On 2021-11-19 17:54 +0100, Fabrice Fontaine spake thusly:
> > This reverts commit 3c2245cb65741c965f4bb87d35ac3c64f250a1ae to move
> > these selects on boost side as the build failure was raised with gcc >=
> > 7.
>
> So, if I understand correctly, if we just apply this revert, but not the
> following patch, we break the build again, right? If so, then it makes
> the history not bi-sectable.
No, basically the patch that I'm reverting is a "no-op".
It does not fix anything as the build failure is raised with gcc >=7,
not gcc < 7.
I made this mistake, because the build failure is only raised since
cmake >= 3.21.3 and
https://github.com/Kitware/CMake/commit/1ad0c5ae53fc0c4f774166337f0e9c93c578cf9b.

cmake has the following behavior:
 - if it "recognizes" the boost version, it will set the boost thread
dependencies to chrono date_time atomic.
 - However, if it does not recognize it (i.e. with cmake < 3.21.3 and
boost 1.77.0), it will set the boost thread dependencies to chrono
atomic.
>
> Instead, the boost patch must be applied first, and once that is done,
> then we can apply this revert.
>
> If the above is correct, just say so, we can re-order the patches when
> applying...
>
> Regards,
> Yann E. MORIN.
>
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
> > ---
> >  package/log4cxx/Config.in | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/package/log4cxx/Config.in b/package/log4cxx/Config.in
> > index 27a5f06988..6f1956f829 100644
> > --- a/package/log4cxx/Config.in
> > +++ b/package/log4cxx/Config.in
> > @@ -12,8 +12,6 @@ config BR2_PACKAGE_LOG4CXX
> >       select BR2_PACKAGE_APR_UTIL
> >       select BR2_PACKAGE_BOOST if !BR2_TOOLCHAIN_GCC_AT_LEAST_7
> >       select BR2_PACKAGE_BOOST_ATOMIC if !BR2_TOOLCHAIN_GCC_AT_LEAST_7
> > -     select BR2_PACKAGE_BOOST_CHRONO if !BR2_TOOLCHAIN_GCC_AT_LEAST_7
> > -     select BR2_PACKAGE_BOOST_DATE_TIME if !BR2_TOOLCHAIN_GCC_AT_LEAST_7
> >       select BR2_PACKAGE_BOOST_THREAD if !BR2_TOOLCHAIN_GCC_AT_LEAST_7
> >       help
> >         Apache log4cxx is a logging framework for C++ patterned
> > --
> > 2.33.0
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot at buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
Best Regards,

Fabrice