[Buildroot] [PATCH/next 1/1] package/pppd: bump to version 2.4.9

[Fabrice Fontaine]

Le dim. 14 nov. 2021 à 14:33, Thomas Petazzoni
<thomas.petazzoni at bootlin.com> a écrit :
>
> On Sun, 14 Nov 2021 12:33:10 +0100
> Fabrice Fontaine <fontaine.fabrice at gmail.com> wrote:
>
> > - Drop patch (already in version)
> > - Update hash of bsd-comp.c, ccp.c and passprompt.c (no change in
> >   license)
> > - rp-pppoe has been renamed to pppoe since
> >   https://github.com/paulusmack/ppp/commit/b2c36e6c0e1655aea9b1b0a03a8160f42a26c884
> > - Manage EAP-TLS which depends on openssl and has been added and is
> >   enabled by default since
> >   https://github.com/paulusmack/ppp/commit/e87fe1bbd37a1486c5223f110e9ce3ef75971f93
>
> I am rather confused by this, especially since you're changing pppd.mk,
> but not the Config.in that has some funky logic:
>
>         select BR2_PACKAGE_OPENSSL if BR2_TOOLCHAIN_USES_GLIBC
>         select BR2_PACKAGE_LIBOPENSSL_ENABLE_DES if BR2_PACKAGE_LIBOPENSSL \
>                                                  && BR2_TOOLCHAIN_USES_GLIBC
>
> Could you explain a bit more how this is intended to work, and what is
> the logic/rationale ?
I'll update the commit message in v2 but basically openssl is still
mandatory with glibc because encrypt and setkey functions have been
removed from glibc 2.28 (cf. commit
b519bcafe75d1256d1fc42aa26393405b89629b3)
>
> Also, I've tested and this 2.4.9 version of pppd build fine with musl,
> so:
>
>         depends on !BR2_TOOLCHAIN_USES_MUSL # Use __P() macro all over the tree
>
> could be dropped.
OK, I'll drop it from v2.

>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com