[Buildroot] [PATCH 4/6] package/luajit: building for 64-bit target requires a 64-bit host for all platform

Yann E. MORIN yann.morin.1998 at free.fr
Fri Nov 12 12:56:08 UTC 2021


Romain, All,

On 2021-11-12 12:00 +0100, Romain Naour spake thusly:
> Currently only x86_64 target requires a 64-bit host but building
> aarch64 target with a 32-bit host is allowed.
> 
> This constraint is for all architectures [1].
> 
> [1] http://lists.busybox.net/pipermail/buildroot/2021-November/628301.html
> 
> Signed-off-by: Romain Naour <romain.naour at gmail.com>
> Cc: Francois Perrad <francois.perrad at gadz.org>
> Cc: Yann E. MORIN <yann.morin.1998 at free.fr>
> ---
>  package/luajit/Config.in | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/package/luajit/Config.in b/package/luajit/Config.in
> index f6d01ed09a..bf98260c31 100644
> --- a/package/luajit/Config.in
> +++ b/package/luajit/Config.in
> @@ -1,13 +1,15 @@
>  config BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
>  	bool
>  	default y if BR2_arm || BR2_armeb || BR2_aarch64
> -	default y if BR2_i386 || (BR2_x86_64 && BR2_HOSTARCH='x86_64')
                                           ,^^^^^^^^^^^^
You removed that _________________________/

> +	default y if BR2_i386 || BR2_x86_64
>  	default y if BR2_powerpc
>  	default y if (BR2_mips || BR2_mipsel) && !BR2_MIPS_SOFT_FLOAT \
>  		&& !BR2_MIPS_CPU_MIPS32R6 && !BR2_MIPS_CPU_MIPS64R6
>  	# -m32 flag is used for 32bit builds and host-luajit has
>  	# limited architecture support
>  	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
> +	# Building for 64-bit target requires a 64-bit host
> +	depends on !BR2_ARCH_IS_64 || BR_HOST_ARCH="x86_64"
                                  ^^^^^^^^^^^^._____
                                                    \
... but you borked it when adding it back here _____/

You should not have blindly copy-pasted my poor code snippet from the
previous review! ;-]

Regards,
Yann E. MORIN.

>  config BR2_PACKAGE_LUAJIT
>  	bool "luajit"
> -- 
> 2.31.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'


More information about the buildroot mailing list