[Buildroot] [PATCH v2] package/luajit: fix luvi

Yann E. MORIN yann.morin.1998 at free.fr
Thu Nov 11 21:06:07 UTC 2021


François, All,

I hit "send" too fast; here's the rest of my review:

The title code should not really be about luvi, but really about laujit.
This patch is not fixing luvi; it is really fixing the build of luajit.
luvi just happens to be the one package that exposed the issue, so it is
not faire to ascribe the fault to it.

Probably something like:

    package/luajit: ensure host and target are built with the same bytecode format

On 2021-11-11 21:56 +0100, Yann E. MORIN spake thusly:
> On 2021-11-10 11:31 +0100, Francois Perrad spake thusly:
> > luvi uses the cross bytecode generation of host-luajit
> > the bytecode format has 2 flavors, depending of GC64 option.
> > 
> > since the commit https://github.com/LuaJIT/LuaJIT/commit/bd00094c3b50e193fb32aad79b7ea8ea6b78ed25
> > GC64 mode is enable by default on all 64bits platform.
> > 
> > with this patch, luajit and host-luajit are built with the same option,
> > so the bytecode generated by host-luajit is valid on luajit.
> > 
> > Signed-off-by: Francois Perrad <francois.perrad at gadz.org>
> > ---
> >  package/luajit/luajit.mk | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/package/luajit/luajit.mk b/package/luajit/luajit.mk
> > index fbbd8ebc7..e93361ba3 100644
> > --- a/package/luajit/luajit.mk
> > +++ b/package/luajit/luajit.mk
> > @@ -26,8 +26,10 @@ endif
> >  # libraries are installed.
> >  ifeq ($(BR2_ARCH_IS_64),y)
> >  LUAJIT_HOST_CC = $(HOSTCC)
> > +LUAJIT_XCFLAGS += -DLUAJIT_ENABLE_GC64

There is not such macro in the LuaJit code.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'


More information about the buildroot mailing list