[Buildroot] [PATCH 1/2] package/glmark2: drm-glesv2 needs libdrm
Yann E. MORIN
yann.morin.1998 at free.fr
Thu Nov 11 20:38:13 UTC 2021
Bernd, All,
On 2021-11-09 21:29 +0100, Bernd Kuhls spake thusly:
> Fixes:
> http://autobuild.buildroot.net/results/58a/58a498fac83cbb55b252ab54cd8db04570bb5ec9/
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls at t-online.de>
> ---
> re-sent deferred patch
> http://patchwork.ozlabs.org/project/buildroot/patch/20200104193919.91589-1-bernd.kuhls@t-online.de/
>
> package/glmark2/Config.in | 3 +++
> package/glmark2/glmark2.mk | 2 +-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/package/glmark2/Config.in b/package/glmark2/Config.in
> index 40d0adcc8a..96b34f971a 100644
> --- a/package/glmark2/Config.in
> +++ b/package/glmark2/Config.in
> @@ -7,7 +7,10 @@ config BR2_PACKAGE_GLMARK2_FLAVOR_DRM_GLESV2
> depends on BR2_PACKAGE_HAS_LIBEGL
> depends on BR2_PACKAGE_HAS_LIBGLES
> depends on BR2_PACKAGE_HAS_UDEV
> + # libpthread-stubs -> libdrm
> + depends on BR2_TOOLCHAIN_HAS_THREADS
> select BR2_PACKAGE_GLMARK2_FLAVOR_ANY
> + select BR2_PACKAGE_LIBDRM
Oh no no no no!
This means that, even if glmark2 is not enabled, then libdrm will
forcibly be enabled in a configuration with libelg, libegls, and udev.
This is not correct *at all*. And IIRC, we already fixed a similar case
not so long ago... Ah, there it is:
b80c488d04 package/kodi: fix selection of dependencies
And now, I also notice that there is already such a bug in glmark2,
where wayland protocols will also forcibly be enabled in a configuration
with egl, gles, and wayland, even when glmark2 is not enabled.
Globally, I think glmark2 needs a bit of refactoring: it is very unusual
that the feature-set is before the main symbol. Usually, we have, in order:
- ARCH_SUPPORTS et al.
- main symbol
- if-block with all options.
- comment(s) about toolchain features et al.
Could you look into that, and respin a full series that fixes all these
issues in glmark2, and adds the missing dependencies, please?
Regards,
Yann E. MORIN.
> config BR2_PACKAGE_GLMARK2_FLAVOR_DRM_GL
> bool
> diff --git a/package/glmark2/glmark2.mk b/package/glmark2/glmark2.mk
> index 5c2dd06362..5ad3ea2cb4 100644
> --- a/package/glmark2/glmark2.mk
> +++ b/package/glmark2/glmark2.mk
> @@ -11,7 +11,7 @@ GLMARK2_LICENSE_FILES = COPYING COPYING.SGI
> GLMARK2_DEPENDENCIES = host-pkgconf jpeg libegl libpng
>
> ifeq ($(BR2_PACKAGE_GLMARK2_FLAVOR_DRM_GLESV2),y)
> -GLMARK2_DEPENDENCIES += libgles udev
> +GLMARK2_DEPENDENCIES += libdrm libgles udev
> GLMARK2_FLAVORS += drm-glesv2
> endif
>
> --
> 2.30.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list