[Buildroot] [PATCH 6/7] board/kontron/pitx-imx8m/genimage.cfg: fix option suffix
Giulio Benetti
giulio.benetti at benettiengineering.com
Tue Nov 9 07:49:22 UTC 2021
Hi Heiko,
> Il giorno 9 nov 2021, alle ore 08:38, Heiko Thiery <heiko.thiery at gmail.com> ha scritto:
>
> Hi Guilio,
>
>
>> Am Di., 9. Nov. 2021 um 00:05 Uhr schrieb Giulio Benetti
>> <giulio.benetti at benettiengineering.com>:
>>
>> Option 'offset = 4k' must be 'option = 4K'.
>
> Is it really a must that the kilobyte value has an uppercase 'k'? From
> the code I see that both k and K are allowed for that. But I have
> nothing against unifying it.
Yes, it’s for unifying, I have to add it to the manual.
>
> Small nitpick here: s/'option = 4K'/option 'offset = 4K'/
Oh, yes, thank you. I reword and send a v2 tonight.
Thank you
Giulio Benetti
Benetti Engineering sas
>
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti at benettiengineering.com>
>> ---
>> board/kontron/pitx-imx8m/genimage.cfg | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/board/kontron/pitx-imx8m/genimage.cfg b/board/kontron/pitx-imx8m/genimage.cfg
>> index c335b0c026..c78ef0f910 100644
>> --- a/board/kontron/pitx-imx8m/genimage.cfg
>> +++ b/board/kontron/pitx-imx8m/genimage.cfg
>> @@ -5,7 +5,7 @@ image sdcard.img {
>> partition imx-boot {
>> in-partition-table = "no"
>> image = "imx8-boot-sd.bin"
>> - offset = 33k
>> + offset = 33K
>> }
>>
>> partition rootfs {
>> --
>> 2.25.1
>
> Acked-by: Heiko Thiery <heiko.thiery at gmail.com>
More information about the buildroot
mailing list