[Buildroot] [PATCH 2/2] configs/qemu_aarch64_sbsa_defconfig: add gitlab runtime testing tag

[D. Olsson]

Hi Romain,

> On 7 Nov 2021, at 20:29, Romain Naour <romain.naour at gmail.com> wrote:
> 
> Enable the runtime testing by adding the tag in the readme.txt
> 
> Signed-off-by: Romain Naour <romain.naour at gmail.com>
> Cc: Dick Olsson <hi at senzilla.io>
> ---
> The gitlab job needs more that 3h to build and execute the test:
> https://gitlab.com/kubu93/buildroot/-/jobs/1755899154
> Tested locally using the Buildroot docker image.
> 
> I'm not sure about the comment about SeaBIOS package, the test works
> fine with the current host-qemu (6.1.0).

Right, host-qemu works great! My CI setup has to rely on qemu packed by Debian, however. And if I recall correctly I ran into some display or VGA related issues with qemu from Debian for the sbsa machine. It was resolved by installing seabios because it adds some drivers to qemu.

It's probably a good idea to leave the comment there for others who might run into the same issue.

> ---
> board/qemu/aarch64-sbsa/readme.txt  | 2 +-
> configs/qemu_aarch64_sbsa_defconfig | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/board/qemu/aarch64-sbsa/readme.txt b/board/qemu/aarch64-sbsa/readme.txt
> index b62947f55f..cf5f66d4d6 100644
> --- a/board/qemu/aarch64-sbsa/readme.txt
> +++ b/board/qemu/aarch64-sbsa/readme.txt
> @@ -23,7 +23,7 @@ Run the emulation with:
>     -nographic \
>     -pflash output/images/SBSA_FLASH0.fd \
>     -pflash output/images/SBSA_FLASH1.fd \
> -    -hda output/images/disk.img
> +    -hda output/images/disk.img # qemu_aarch64_sbsa_defconfig
> 
> Note that if you want to run sbsa-ref emulation with QEMU provided by
> your distro (i.e., not host-qemu by Buildroot) then you may need to
> diff --git a/configs/qemu_aarch64_sbsa_defconfig b/configs/qemu_aarch64_sbsa_defconfig
> index d1e0adadd1..e7d3bd03ca 100644
> --- a/configs/qemu_aarch64_sbsa_defconfig
> +++ b/configs/qemu_aarch64_sbsa_defconfig
> @@ -16,8 +16,8 @@ BR2_TARGET_ROOTFS_EXT2_4=y
> BR2_TARGET_ROOTFS_EXT2_SIZE="128M"
> 
> # Image
> -BR2_ROOTFS_POST_IMAGE_SCRIPT="board/qemu/aarch64-sbsa/assemble-flash-images support/scripts/genimage.sh"
> -BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/qemu/aarch64-sbsa/genimage.cfg"
> +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/qemu/post-image.sh board/qemu/aarch64-sbsa/assemble-flash-images support/scripts/genimage.sh"
> +BR2_ROOTFS_POST_SCRIPT_ARGS="$(BR2_DEFCONFIG) -c board/qemu/aarch64-sbsa/genimage.cfg"
> 
> # Linux headers same as kernel
> BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
> -- 
> 2.31.1

Looks good!

Reviewed-by: Dick Olsson <hi at senzilla.io>