[Buildroot] [git commit branch/2021.08.x] utils/getdeveloperlib.py: call Developer.hasfile() with relative path

Peter Korsgaard peter at korsgaard.com
Wed Nov 3 21:14:39 UTC 2021


commit: https://git.buildroot.net/buildroot/commit/?id=1830075c47b974848c150c91d705523bec183367
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/2021.08.x

In commit
40bb37bd70d46822e803aaa5169dee8ff8b51093 ("utils/getdeveloperlib.py:
use relative paths for files"), the Developer class was changed to use
relative paths, including for its .hasfile() method.

However the check_developers() function of getdeveloperlib.py was not
updated accordingly, and continued to pass absolute paths. This caused
"get-developers -c" to return the entire list of files in Buildroot as
being unmaintained, as none of them were matching the file listed in
the DEVELOPERS file.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
(cherry picked from commit 79cba4056b0d7c81490262f354bab1cc1ce33267)
Signed-off-by: Peter Korsgaard <peter at korsgaard.com>
---
 utils/getdeveloperlib.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/utils/getdeveloperlib.py b/utils/getdeveloperlib.py
index 971d69fef5..e686bc793f 100644
--- a/utils/getdeveloperlib.py
+++ b/utils/getdeveloperlib.py
@@ -283,7 +283,7 @@ def check_developers(developers, basepath=None):
     for f in files:
         handled = False
         for d in developers:
-            if d.hasfile(os.path.join(basepath, f)):
+            if d.hasfile(f):
                 handled = True
                 break
         if not handled:


More information about the buildroot mailing list