[Buildroot] [PATCH] package/mender-grubenv: fix grub module checks

Thomas Petazzoni thomas.petazzoni at bootlin.com
Wed Nov 3 21:19:50 UTC 2021


Hello Adam,

On Wed,  3 Nov 2021 12:55:19 -0700
Adam Duskett <aduskett at gmail.com> wrote:

> +ifeq ($(BR2_TARGET_GRUB2_X86_64_EFI),y)

Are you sure this is correct? Indeed I believe
BR2_TARGET_GRUB2_BUILTIN_MODULES_EFI is also used for the
BR2_TARGET_GRUB2_I386_EFI, BR2_TARGET_GRUB2_ARM_EFI and
BR2_TARGET_GRUB2_ARM64_EFI cases, isn't it ?



> +MENDER_GRUBENV_MODULES_MISSING = \
> +	$(filter-out $(call qstrip,$(BR2_TARGET_GRUB2_BUILTIN_MODULES_EFI)),\
> +		$(MENDER_GRUBENV_MANDATORY_MODULES))
> +else
>  MENDER_GRUBENV_MODULES_MISSING = \
>  	$(filter-out $(call qstrip,$(BR2_TARGET_GRUB2_BUILTIN_MODULES)),\

Also BR2_TARGET_GRUB2_BUILTIN_MODULES no longer exists, it's
BR2_TARGET_GRUB2_BUILTIN_MODULES_PC.

I'm really sorry we overlooked this when doing the changes on grub2 :-/

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com


More information about the buildroot mailing list