[Buildroot] [PATCH 1/5] package/alchemy: new host package
Thomas Petazzoni
thomas.petazzoni at bootlin.com
Wed Nov 3 17:30:06 UTC 2021
Hello Hervé,
On Wed, 3 Nov 2021 18:20:47 +0100
Herve Codina <herve.codina at bootlin.com> wrote:
> > The kconfig code is under GPL-2.0.
>
> I missed this one.
>
> The GPL-2.0 license file is not provided by Alchemy.
> They mention 'kconfig source code is GPLv2' in their README file.
>
> ALCHEMY_LICENSE = BSD-3-Clause (Alchemy), GPL-2.0 (kconfig)
> ALCHEMY_LICENSE_FILES = COPYING README
>
> Is that correct from Buildroot even if the GLP-2.0 license file is not
> provided ?
Yes, that's fine.
> > > + $(TARGET_MAKE_ENV) \
> > > + ALCHEMY_HOME=$(ALCHEMY_HOME) \
> > > + ALCHEMY_WORKSPACE_DIR="$(@D)" \
> > > + ALCHEMY_TARGET_OUT=alchemy-out \
> > > + TARGET_OS=linux \
> > > + TARGET_OS_FLAVOUR=buildroot \
> > > + TARGET_CROSS="$(TARGET_CROSS)" \
> > > + TARGET_ARCH=xxx \
> >
> > Is this intended ?
>
> Yes, it is to avoid the internal Alchemy arch management.
>
> It can lead to incorrect results with the toolchain we
> provided in TARGET_CROSS. Indeed they add some CFLAGS
> depending on given TARGET_ARCH.
> To avoid issues, this was the simplest way I found to say
> 'Hey Alchemy, do not care about the arch, I do it for you'.
>
> Maybe this breaks some internal parts such as building a
> CMake or an autotools package but in the buildroot context,
> A CMake or an autotools package will not be built by Alchemy.
>
> I will add a comment in v2.
Thanks for the explanation. Adding a comment in the code will
definitely be useful to clear up what's happening with this TARGET_ARCH
variable.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
More information about the buildroot
mailing list