[Buildroot] [PATCH 2/5] package/ulog: new package

[Herve Codina]

Hi,

On Wed, 3 Nov 2021 16:47:01 +0100
Thomas Petazzoni <thomas.petazzoni at bootlin.com> wrote:

> On Wed,  3 Nov 2021 08:36:53 +0100
> Herve Codina <herve.codina at bootlin.com> wrote:
> 
> > +ULOG_VERSION = 0389d243352255f6182326dccdae3d56dadc078f
> > +ULOG_SITE = $(call github,Parrot-Developers,ulog,$(ULOG_VERSION))
> > +ULOG_LICENSE = Apache-2.0
> > +ULOG_LICENSE_FILES = COPYING
> > +ULOG_DEPENDENCIES = host-alchemy
> > +ULOG_INSTALL_STAGING = YES
> > +
> > +define ULOG_BUILD_CMDS
> > +	$(ALCHEMY_TARGET_CONFIGURE_ENV) \
> > +	$(ALCHEMY_MAKE) libulog  
> 
> Please indent the continuation line.

Will be done in v2.

> 
> > +define ULOG_INSTALL_STATIC_LIBS
> > +	$(INSTALL) -m 644 $(@D)/alchemy-out/staging/usr/lib/libulog.a $(strip $(1))/usr/lib/
> > +endef  
> 
> I am not entirely sure we need to $(strip ...) the $(1) argument here
> and in other macros. We have several other places in Buildroot for
> similar situations where we don't strip $(1). (Note: this is not a very
> important comment.)

I will remove this kind of $(strip ...) in v2.

> 
> Thanks,
> 
> Thomas

Thanks fr the review.

Hervé

-- 
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com