[Buildroot] [PATCHv3 11/15] package/sofia-sip: use BR2_ENABLE_RUNTIME_DEBUG iso BR2_ENABLE_DEBUG

[Thomas De Schampheleire]

El mar, 25 may 2021 a las 23:32, Arnout Vandecappelle
(<arnout at mind.be>) escribió:
>
>
>
> On 25/05/2021 14:27, Thomas De Schampheleire wrote:
> > From: Thomas De Schampheleire <thomas.de_schampheleire at nokia.com>
> >
> > BR2_ENABLE_DEBUG should just steer the availability of debug symbols and
> > should have no negative effect on performance.
> >
> > Introduction of 'assert' statements, 'debug'-type builds with additional
> > logging, etc. should be steered by BR2_ENABLE_RUNTIME_DEBUG instead.
> >
> > Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire at nokia.com>
> > ---
> >  package/sofia-sip/sofia-sip.mk | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/sofia-sip/sofia-sip.mk b/package/sofia-sip/sofia-sip.mk
> > index 5c383400ff..cb867ba0dc 100644
> > --- a/package/sofia-sip/sofia-sip.mk
> > +++ b/package/sofia-sip/sofia-sip.mk
> > @@ -30,7 +30,7 @@ SOFIA_SIP_CONF_OPTS += \
> >       --without-openssl
> >  endif
> >
> > -ifeq ($(BR2_ENABLE_DEBUG),y)
> > +ifeq ($(BR2_ENABLE_RUNTIME_DEBUG),y)
> >  SOFIA_SIP_CONF_OPTS += --enable-ndebug
>
>  Actually, the logic was inverted here (already wrong in the current situation):
> --enable-ndebug should be given when RUNTIME_DEBUG is *not* set.

Indeed, you're right. I'll add a patch to fix that first.

>
>  However, I think we should define -DNDEBUG in TARGET_CPPFLAGS, so it wouldn't
> be necessary to pass it explicitly here (--enable-ndebug does nothing more than
> defining NDEBUG).
>

In a previous iteration I basically did that, but dropped that patch
because it also had effect in the toolchain wrapper, which may be used
to build project-specific projects, and which caused compilation
failures when NDEBUG was unexpectedly set (e.g. variables only used
for assert statements, which got compiled away with NDEBUG). Granted,
this is actually a problem in such code, but nevertheless it was my
reality and I expect those of others too.
See http://patchwork.ozlabs.org/project/buildroot/patch/20210212135451.22786-3-patrickdepinguin@gmail.com/
   and my last comment on it.

Best regards,
Thomas