[Buildroot] [PATCHv3 00/15] Introduce BR2_ENABLE_RUNTIME_DEBUG
Arnout Vandecappelle
arnout at mind.be
Tue May 25 20:32:45 UTC 2021
On 25/05/2021 14:27, Thomas De Schampheleire wrote:
> From: Thomas De Schampheleire <thomas.de_schampheleire at nokia.com>
>
> Hello,
>
> This patch series started with as main goal to fix the performance degradation
> found when testing gRPC in combination with BR2_ENABLE_DEBUG.
>
> Its implementation strives to settle a discussion that has happened several
> times, regarding the CMAKE_BUILD_TYPE that Buildroot should set, by not forcing
> anything upon the user but allowing the choice.
>
> Additionally, it cleans up some related changes done in specific packages.
>
> After this series, there are still packages that set CMAKE_BUILD_TYPE
> explicitly, but the associated comments indicate that they are needed to avoid
> build failures, so they are not touched.
There are probably also lots of (non-cmake) packages that have options that
should depend on this new config option, but we don't need to fix the world
right away.
For the record: I'm in agreement with this series (with some small comments
which I'll make in individual patches). However, it's a bit too controversial
for me to apply outright, so I'm waiting for acks from other developers.
Regards,
Arnout
>
> v2: fix sysrepo after comment by Jan Kundrát (thanks!)
> v3:
> - new patch setting -g0 (Arnout)
> - don't set -DNDEBUG globally anymore, and drop related libjson change
> - flare-engine, supertux: retain disabling of -pg option (Arnout)
> - sysrepo: new patch for host-sysrepo, disable tests for target (Arnout)
> - update several packages to use BR2_ENABLE_RUNTIME_DEBUG instead of
> BR2_ENABLE_DEBUG
>
>
> Thomas De Schampheleire (15):
> package/Makefile.in: pass '-g0' explicitly if !BR2_ENABLE_DEBUG
> core: introduce BR2_ENABLE_RUNTIME_DEBUG
> package/pkg-cmake.mk: determine CMAKE_BUILD_TYPE depending on
> BR2_ENABLE_RUNTIME_DEBUG
> package/flare-engine: update explicit setting of CMAKE_BUILD_TYPE
> package/sysrepo: use default CMAKE_BUILD_TYPE for host package
> package/sysrepo: remove explicit setting of CMAKE_BUILD_TYPE
> package/boost: use BR2_ENABLE_RUNTIME_DEBUG iso BR2_ENABLE_DEBUG
> package/oracle-mysql: use BR2_ENABLE_RUNTIME_DEBUG iso
> BR2_ENABLE_DEBUG
> package/qt5: use BR2_ENABLE_RUNTIME_DEBUG iso BR2_ENABLE_DEBUG
> package/ripgrep: use BR2_ENABLE_RUNTIME_DEBUG iso BR2_ENABLE_DEBUG
> package/sofia-sip: use BR2_ENABLE_RUNTIME_DEBUG iso BR2_ENABLE_DEBUG
> package/uclibc: use BR2_ENABLE_RUNTIME_DEBUG iso BR2_ENABLE_DEBUG
> package/zmqpp: use BR2_ENABLE_RUNTIME_DEBUG iso BR2_ENABLE_DEBUG
> package/pkg-meson.mk: determine 'buildtype' based on
> BR2_ENABLE_RUNTIME_DEBUG iso BR2_ENABLE_DEBUG
> utils/genrandconfig: also test BR2_ENABLE_RUNTIME_DEBUG
>
> Config.in | 13 +++++++++++++
> docs/manual/adding-packages-cmake.txt | 2 +-
> package/Makefile.in | 3 +++
> package/boost/boost.mk | 2 +-
> package/flare-engine/flare-engine.mk | 2 +-
> package/oracle-mysql/oracle-mysql.mk | 2 +-
> package/pkg-cmake.mk | 2 +-
> package/pkg-meson.mk | 2 +-
> package/qt5/qt5base/qt5base.mk | 2 +-
> package/ripgrep/ripgrep.mk | 2 +-
> package/sofia-sip/sofia-sip.mk | 2 +-
> package/sysrepo/sysrepo.mk | 9 ++++++---
> package/uclibc/uclibc.mk | 2 +-
> package/zmqpp/zmqpp.mk | 2 +-
> utils/genrandconfig | 2 ++
> 15 files changed, 35 insertions(+), 14 deletions(-)
>
More information about the buildroot
mailing list