[Buildroot] [PATCH 3/3] boot/at91bootstrap3: add BR2_TARGET_AT91BOOTSTRAP3_NEEDS_PYTHON3

[Thomas Petazzoni]

On Wed, 19 May 2021 11:29:23 +0000
<Eugen.Hristev at microchip.com> wrote:

> > diff --git a/boot/at91bootstrap3/Config.in b/boot/at91bootstrap3/Config.in
> > index 18301a0dc0..966e393db5 100644
> > --- a/boot/at91bootstrap3/Config.in
> > +++ b/boot/at91bootstrap3/Config.in
> > @@ -101,3 +101,11 @@ config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_CONFIG_FILE
> >            Path to the at91bootstrap3 configuration file
> > 
> >   endif # BR2_TARGET_AT91BOOTSTRAP3
> > +
> > +config BR2_TARGET_AT91BOOTSTRAP3_NEEDS_PYTHON3
> > +       bool "needs host-python3"  
> 
> Hi,
> 
> This prompt that appears in menuconfig is a bit unfriendly : it does not 
> say who needs the host-python3, and it does not appear to be in the 
> at91bootstrap3 -related options.
> It is at the same indentation level as the other bootloaders, like 
> Barebox, Grub, etc. So I think it's misleading and should be aligned 
> with the other At91bootstrap options

Crap, you're entirely right, it is misplaced: it should have been just
two line above, within the if BR2_TARGET_AT91BOOTSTRAP3 ... endif block.

Unless someone beats me at it, I'll send a patch fixing that.

Thanks for spotting this!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com