[Buildroot] [PATCH v1 1/3] package/libtomcrypt: add pkgconfig support

[Peter Seiderer]

Hello Arnout,

On Sat, 1 May 2021 15:18:42 +0200, Arnout Vandecappelle <arnout at mind.be> wrote:

> On 12/04/2021 23:15, Peter Seiderer wrote:
> > Hello Thomas,
> >
> > On Mon, 12 Apr 2021 22:14:53 +0200, Thomas Petazzoni <thomas.petazzoni at bootlin.com> wrote:
> >
> >> On Mon, 12 Apr 2021 21:55:25 +0200
> >> Peter Seiderer <ps.report at gmx.net> wrote:
> >>
> >>> Signed-off-by: Peter Seiderer <ps.report at gmx.net>
> >>
> >> Is there any specific motivation? Does this had a chance of going
> >> upstream ?
> >
> > For an custom project, previously developed on with cmake on ubuntu (which
> > provides the pkgconfig file)....
> >
> > Can try to suggest upstream...
>
>  Adding a .pc file in Buildroot usually doesn't make much sense, because no
> package that depends on it is going to use it. So yes, please organise this
> upstream.

But a buildroot provided library should be usable for buildroot packages AND
out-of-tree/custom packages?

Nevertheless, did take a second look at the libtomcrypt sources, already
providing a libtomcrypt.pc.in template (but only used/installed in case
of 'makefile.shared'/'makefile.unix' and the buildroot compile uses the
default 'makefile' one)...

Regards,
Peter

>
>  Therefore, I've marked this patch as Rejected.
>
>  Regards,
>  Arnout