[Buildroot] [PATCH] package/zeromq: fix build failure due to binutils bug 21464

Giulio Benetti giulio.benetti at benettiengineering.com
Mon Mar 22 15:57:23 UTC 2021


On 3/22/21 2:42 PM, Thomas Petazzoni wrote:
> On Mon, 22 Mar 2021 14:15:08 +0100
> Giulio Benetti <giulio.benetti at benettiengineering.com> wrote:
> 
>> OpenRisc binutils 21464 bug has a fix:
>> https://sourceware.org/bugzilla/show_bug.cgi?id=21464
>>
>> I've tested it with binutils:
>> - 2.32
>> - 2.34
>> - 2.35.2
>> - 2.36.1
>>
>> and works good while building:
>> - protobuf
>> - libtheora
>> - zeromq
> Excellent! Thanks for all this work!
> 
> Has this fix been suggested by upstream? How do you know it's the
> "right" fix ?

Yes it's been suggested by Stafford here:
https://sourceware.org/bugzilla/show_bug.cgi?id=21464

>> zeromq is the only package that could be worked around with -O0.
>>
>> I would add patches that add patches to all binutils versions, so this
>> way buildroot toolchain built by buildroot are safe, but I should tag
>> as buggy all the external openrisc toolchains, basically the one
>> provided by Bootlin. This implies adding patches to disable building
>> libtheora with all its dependencies and I can do it, or otherwise we can
>> wait for Bootlin to release a new fixed openrisc toolchain, what about that?
> 
> Don't bother with the external Bootlin toolchains, I was working on a
> new release of the toolchains based on 2021.02, so I'll include the
> binutils fix.

Ok, so it fixes this bug for Buildroot toolchain and you'll provide 
Bootlin toolchain and we can consider this bug as not affecting
Buildroot anymore. The chance one would use an external OpenRisc 
toolchain would be very rare. Right?

Then we could revert commit:
"package/protobuf: disable package if binutils is affected from bug 21464"
https://git.buildroot.net/buildroot/commit/?id=9e71b6e2cb

While doing all these tests I've gound that libgeos still has this bug 
and most of all, the diff proposed doesn't fix bug 21464, they are 2 
different bugs, so I've updated that here:
https://sourceware.org/bugzilla/show_bug.cgi?id=21464

And submitted the other bug:
https://sourceware.org/bugzilla/show_bug.cgi?id=27624

So bug 21464 is still there and my binutils patches need do be re-worded.

And please drop my pending patch:
https://patchwork.ozlabs.org/project/buildroot/patch/20210322131437.392225-1-giulio.benetti@benettiengineering.com/

I've submitted a reworded one:
https://patchwork.ozlabs.org/project/buildroot/patch/20210322155655.547476-1-giulio.benetti@benettiengineering.com/

Best regards
-- 
Giulio Benetti
Benetti Engineering sas


More information about the buildroot mailing list