[Buildroot] [PATCH v1 2/2] package/batman-adv: enable B.A.T.M.A.N. V protocol by default

Christian Stewart christian at paral.in
Mon Mar 15 20:49:02 UTC 2021


Yann,

On Mon, Mar 15, 2021 at 12:59 PM Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
> >  config BR2_PACKAGE_BATMAN_ADV_BATMAN_V
> > -     bool "enable B.A.T.M.A.N. V protocol (experimental)"
> > +     bool "enable B.A.T.M.A.N. V protocol"
>
> Upstream seems to still consider this to be experimental [0].
>
> > +     default y
>
> What we talked about earlier [1], was to always enable it, not to change
> the default.
>
> Now, people that have a defconfig file with BATMAN-V disabled (i.e.
> there would be nothing in the defconfig as 'is not set' is the default),
> will have it enabled now.
>
> So, if upstream recommends to not disable it (do you have a ref?), then
> we should just drop our option, and to always enable it.
>
> Thoughts?
>
> [0] https://git.open-mesh.org/batman-adv.git/blob/HEAD:/Makefile#l7
> [1] http://lists.busybox.net/pipermail/buildroot/2021-March/305811.html

What would the advantage be for removing the ability to disable the
CONFIG_BATMAN_ADV_BATMAN_V option from the Buildroot config?

I guess if someone doesn't need it it could still be good to remove to
simplify things.

Best,
Christian


More information about the buildroot mailing list