[Buildroot] [PATCH 4/4] package/mender: Do not automatically select uboot tools if uboot is selected

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sun Mar 14 22:15:07 UTC 2021


Hello Adam,

On Sun,  7 Mar 2021 14:25:36 -0800
aduskett at gmail.com wrote:

> diff --git a/package/mender/Config.in b/package/mender/Config.in
> index 6a80c410ce..6c84157734 100644
> --- a/package/mender/Config.in
> +++ b/package/mender/Config.in
> @@ -5,14 +5,24 @@ config BR2_PACKAGE_MENDER
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	select BR2_PACKAGE_OPENSSL
>  	select BR2_PACKAGE_XZ
> -	select BR2_PACKAGE_UBOOT_TOOLS if BR2_TARGET_UBOOT # runtime
> -	select BR2_PACKAGE_UBOOT_TOOLS_FWPRINTENV if BR2_TARGET_UBOOT # runtime

It's a bit odd to drop these.

>  	help
>  	  Mender is an open source over-the-air (OTA) software updater
>  	  for embedded Linux devices. Mender comprises a client
>  	  running at the embedded device, as well as a server that
>  	  manages deployments across many devices.
>  
> +	  Note:
> +	  For systems using uboot as the bootloader:
> +	    - uboot must be patched with the mender uboot patches.
> +	    - uboot-tools must be selected.
> +	    - fw_printenv must be functional on the device.

Indeed, here you are precisely saying that fw_printenv is needed. What
about keeping the selects *and* adding your Config.in comment, perhaps
without the "uboot-tools must be selected". It would be nice to have
some more specific reference to the Mender U-Boot patches.

> +	  For systems using Grub as the bootloader:
> +	    - Mender depends on the mender-grubenv package.

What about selecting BR2_PACKAGE_MENDER_GRUBENV then when
BR2_TARGET_GRUB is enabled?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list