[Buildroot] [PATCH 04/15] package/pkg-generic.mk: Fix .la files overwrite detection

Thomas Petazzoni thomas.petazzoni at bootlin.com
Tue Jun 22 10:12:20 UTC 2021


On Tue, 22 Jun 2021 11:56:09 +0200
"Yann E. MORIN" <yann.morin.1998 at free.fr> wrote:

> Sorry, but this patch (4/15) is fixing an issue introduced by the first
> patch, with:

I agree in principle. But here, it's really a new requirement that we
are adding on packages, and we *know* that even with Hervé patches
there will be some other packages that will need fixing.

So to me it's not really like introducing a regression in a patch, and
fixing it later.

> > What about the others issues
> > detected ? Squash also together with the first patch ? I think it will
> > produce a huge patch quite complicate to understand even with all individual
> > commit message squashed.  
> 
> Ideally, I would say a series should first fix the issues, then
> introduce the tooling.

No, please keep one series, but having the fixes *before* we introduce
the check. And as stated above, the fixes will not fix all problems,
they will only fix the problems we know about. More problems will be
detected by the autobuilders thanks to the overwrite check.

> > However, that being said, I can squash this patch (Fix .la files overwrite
> > detection) with the 1st one (detect files overwritten in TARGET_DIR and
> > HOST_DIR) if you still think it will be better.  
> 
> Yes, I still think that it is better.

No, please don't squash, have fixes added before the overwrite check
instead.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list