[Buildroot] [PATCH v5 0/5] Introduce bmap-tools as target + host package

Nicolas Carrier nicolas.carrier at orolia.com
Wed Jun 9 07:35:38 UTC 2021


Hello,
I've tested the patch series in both the current master and by applying
it to our fork, which is based of 2020.02.11 and, after resolving the
conflicts with our branch (mainly in the DEVELOPERS file), I could test
it in both.

* the target package works fine
* so does the host package
* the tests TestPy3BmapTools and TestPy2BmapTools are failing at run
time.

The first error in the run log is:

qemu-system-arm: Invalid SD card size: 60 MiB
SD card size has to be a power of 2, e.g. 64 MiB.

So I set a fixed image size of 64M.
With this modification, the python 2 test passes, but with that, the
python 3 one, fails with a timeout issue:

...
  File "/usr/lib/python3/dist-packages/pexpect/expect.py", line 181, in
expect_loop
    return self.timeout(e)
  File "/usr/lib/python3/dist-packages/pexpect/expect.py", line 144, in
timeout
    raise exc
pexpect.exceptions.TIMEOUT: Timeout exceeded.
...

By increasing the timeout to 60 seconds, I could have all the tests
passing.

I attached my diff for reference.


And I have a question, is keeping python 2 compatibility still
required? Shouldn't we get rid of this test? It'd save quite an amount
of CPU time :)


On Mon, 2021-06-07 at 22:42 +0200, Thomas Petazzoni wrote:
> CAUTION: This email originated from outside of the organization.
> Do not click links or open attachments unless you recognize the
> sender and know the content is safe.
> 
> Hello,
> 
> Back in 2019, Nicolas Carrier started a patch series on bmap-tools,
> which was kind of abandonned after 4 iterations. I'm now trying to
> pick it up and revive it.
> 
> Compared to the v4 from Nicolas:
> 
>  - Checked the list of optional runtime dependencies that bmap-tools
>    can use, as suggested by Romain Naour, and added some explanations
>    in the Config.in help text about them. There is not much more we
>    can do about them in Buildroot: they are not optional build time
>    dependencies, but only runtime dependencies, and only needed when
>    certain features are needed (so there is no reason to make them
>    mandatory dependencies).
> 
>  - Added the missing pyexpat runtime dependency.
> 
>  - Drop incorrect build-time dependencies, which are only runtime
> ones
>    (target python-setuptools)
> 
>  - Update to the latest version of bmap-tools
> 
>  - Misc improvements to the test cases, migration to a newer
> toolchain
>    that doesn't exhibit an fallocate() bug. Moving to a newer
>    toolchain requires updating the pre-built kernel image used for
> the
>    runtime test infrastructure.
> 
>  - Added a host variant for the bmap-tools package, as this tool can
>    also be very useful on the host to optimize the time needed to
>    write an image. This host bmap-tools package comes with a test
> case
>    as well.
> 
> Thanks!
> 
> Thomas Petazzoni
> 
> Nicolas Carrier (2):
>   package/bmap-tools: new package
>   support/testing/tests/package/test_bmap_tools: new test
> 
> Thomas Petazzoni (3):
>   package/bmap-tools: enable host package
>   support/testing/infra/emulator.py: update pre-built kernels
>   support/testing/tests/package/test_bmap_tools: add test for host
>     bmap-tools
> 
>  DEVELOPERS                                    |  6 ++
>  package/Config.in                             |  1 +
>  package/Config.in.host                        |  1 +
>  package/bmap-tools/Config.in                  | 44 ++++++++++
>  package/bmap-tools/Config.in.host             | 12 +++
>  package/bmap-tools/bmap-tools.hash            |  3 +
>  package/bmap-tools/bmap-tools.mk              | 14 +++
>  support/testing/infra/emulator.py             |  8 +-
>  .../tests/package/sample_bmap_tools.sh        | 15 ++++
>  .../testing/tests/package/test_bmap_tools.py  | 88
> +++++++++++++++++++
>  10 files changed, 188 insertions(+), 4 deletions(-)
>  create mode 100644 package/bmap-tools/Config.in
>  create mode 100644 package/bmap-tools/Config.in.host
>  create mode 100644 package/bmap-tools/bmap-tools.hash
>  create mode 100644 package/bmap-tools/bmap-tools.mk
>  create mode 100755
> support/testing/tests/package/sample_bmap_tools.sh
>  create mode 100644 support/testing/tests/package/test_bmap_tools.py
> 
> --
> 2.31.1
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: minor_bmap_tests_fixes.patch
Type: text/x-patch
Size: 901 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20210609/aeb3bd68/attachment-0002.bin>


More information about the buildroot mailing list