[Buildroot] [PATCH v2 1/1] package/libtirpc: add missing !BR2_STATIC_LIBS dependency

[Petr Vorel]

Hi James,

> Signed-off-by: James Hilliard <james.hilliard1 at gmail.com>
> ---
> Changes v1 -> v2:
>   - add comment requiring dynamic libraries
> ---
>  package/libtirpc/Config.in | 6 ++++++
>  1 file changed, 6 insertions(+)

> diff --git a/package/libtirpc/Config.in b/package/libtirpc/Config.in
> index 1899edefbf..31f1636ef5 100644
> --- a/package/libtirpc/Config.in
> +++ b/package/libtirpc/Config.in
> @@ -10,6 +10,7 @@ config BR2_PACKAGE_LIBTIRPC
>  config BR2_PACKAGE_LIBTIRPC_GSS
>  	bool "gss"
>  	depends on BR2_USE_MMU # libkrb5
> +	depends on !BR2_STATIC_LIBS # libkrb5
>  	depends on BR2_PACKAGE_LIBTIRPC
>  	select BR2_PACKAGE_LIBKRB5
>  	help
> @@ -17,3 +18,8 @@ config BR2_PACKAGE_LIBTIRPC_GSS

>  comment "libtirpc needs a toolchain w/ threads"
>  	depends on !BR2_TOOLCHAIN_HAS_THREADS
> +
> +comment "libtirpc gss support needs a toolchain w/ dynamic library"
> +	depends on BR2_USE_MMU
> +	depends on BR2_STATIC_LIBS
> +	depends on BR2_PACKAGE_LIBTIRPC
Shouldn't the last item depend on BR2_PACKAGE_LIBTIRPC_GSS?
I'd also name it "libtirpc GSS support ..." (capitalize GSS)

Kind regards,
Petr