[Buildroot] [PATCH] package/nfs-utils: fix printfs format build failure on 64-bits platforms

Giulio Benetti giulio.benetti at benettiengineering.com
Sun Jul 25 21:15:24 UTC 2021


Hi Petr,

On 7/25/21 11:11 PM, Petr Vorel wrote:
> Hi Giulio,
> 
>> Add 2 pending upstream patches that have been pointed to nfs-utils
>> maintainer to be committed soon. They both fix the build failure on 64-bits
>> where time_t is assumed to be a long long when passed to printf("%ld"), but
>> that is not always true, so in these patches the author(Petr) uses PRIu64
>> tag.
> 
>> Fixes:
>> http://autobuild.buildroot.net/results/9bc1d43a588338b7395af7bc97535ee16a6ea2d9/
> 
>> Signed-off-by: Giulio Benetti <giulio.benetti at benettiengineering.com>
>> Cc: Petr Vorel <petr.vorel at gmail.com>
> 
> Reviewed-by: Petr Vorel <petr.vorel at gmail.com>
> 
> Although I'd wait till Monday, when Steve merges them and then add
> upstream commit hashes.

Oh, usually here they accept pending patches, so I don't think that SHA1 
is that important. At least this is what I've experienced until now.

> Or at least add links from lore.
> https://lore.kernel.org/linux-nfs/20210722161545.26923-1-petr.vorel@gmail.com/
> https://lore.kernel.org/linux-nfs/20210722161545.26923-2-petr.vorel@gmail.com/
But yes, I've forgotten to mention that they are pending there ^^^.

Let's see what Buildroot maintainers answer. Otherwise I send a v2 with 
update commit log pointint the links where those patches are committed 
or pending.

Thanks a lot for reviewing

Kind regards
-- 
Giulio Benetti
Benetti Engineering sas


More information about the buildroot mailing list