[Buildroot] [PATCHv4 02/16] core: enable 'NDEBUG' unless BR2_ENABLE_RUNTIME_DEBUG is set

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at bootlin.com> writes:

 > Hello,
 > On Tue,  1 Jun 2021 16:34:07 +0200
 > Thomas De Schampheleire <patrickdepinguin at gmail.com> wrote:

 >> From: Thomas De Schampheleire <thomas.de_schampheleire at nokia.com>
 >> 
 >> The 'assert' statement in glibc honors the 'NDEBUG' preprocessor macro: if
 >> it is set, then the assert statement is compiled away.
 >> 
 >> Define this 'NDEBUG' macro when BR2_ENABLE_RUNTIME_DEBUG is disabled (the
 >> default case).
 >> 
 >> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire at nokia.com>

 > So, I would like to challenge whether this change is really a good
 > idea. Since this has been merged, we had to add a significant number of
 > patches to undefine NDEBUG.

Indeed.

 > I believe this change is too dangerous, has caused a number of build
 > breakage + can cause run-time breakage that is difficult to predict.

 > What do you think ?

I agree, I don't think it ends up being a net positive regarding
cost/benefit. I would prefer to revert it.

-- 
Bye, Peter Korsgaard