[Buildroot] [PATCH 2/2] package/uboot-tools: env/script generation need BINARIES_DIR

[Matthew Weber]

Thomas/Yann,


On Mon, Jan 25, 2021 at 3:18 PM Thomas Petazzoni
<thomas.petazzoni at bootlin.com> wrote:
>
> On Mon, 25 Jan 2021 08:57:42 -0600
> Matt Weber <matthew.weber at rockwellcollins.com> wrote:
>
> > From: Kalpesh Panchal <kalpesh.panchal at rockwellcollins.com>
> >
> > The host build of uboot-tools can occur early in the build process and may
> > require the creation of BINARIES_DIR before generation of an enabled envimage
> > and/or boot script binary.
> >
> > Signed-off-by: Kalpesh Panchal <kalpesh.panchal at rockwellcollins.com>
> > Signed-off-by: Matt Weber <matthew.weber at rockwellcollins.com>
>
> Hum, while this works, I'm in fact not too happy with the proposed
> solution. I would prefer that we move the mkenvimage/$(MKIMAGE)
> invocations to a BUILD_CMDS step, that produces its results in $(@D),
> and then INSTALL_CMDS does a $(INSTALL) ... of that file, which with
> the -D option would create $(BINARIES_DIR).
>
> I know it's a bit bike-shedding, but it feels a little bit better. What
> do you think ?

I've added Yann to the discussion as he suggested the mkdir :-)

Whatever is better to maintain.

-Matt