[Buildroot] [PATCHv2 2/2] package/zstd: link programs dynamically with libzstd to save space

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sun Jan 17 14:31:11 UTC 2021


On Fri,  4 Dec 2020 10:57:02 +0100
Thomas De Schampheleire <patrickdepinguin at gmail.com> wrote:

> From: Thomas De Schampheleire <thomas.de_schampheleire at nokia.com>
> 
> Even when a shared libzstd is built, the zstd command-line programs are
> statically linked with libzstd, causing a large rootfs footprint.
> 
> While the cmake backend in zstd already supported a flag
> ZSTD_PROGRAMS_LINK_SHARED, the make backend did not.
> 
> This commit adds support for ZSTD_PROGRAMS_LINK_SHARED in the make system
> and applies it for the target compilation, unless only static libs are
> supported.
> 
> See https://github.com/facebook/zstd/issues/2261 .
> 
> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire at nokia.com>
> ---
> v2: no functional changes other than splitting off part to a separate patch

I've marked as Changes Requested, as you proposed in the review of
PATCH 1/2 in this series.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list