[Buildroot] [PATCH 1/1] package/dotnet-sdk: new package
Thomas Petazzoni
thomas.petazzoni at bootlin.com
Tue Jan 12 15:19:35 UTC 2021
Hello Raul,
On Tue, 12 Jan 2021 16:07:23 +0100
Raul Hidalgo Caballero <deinok at deinok.com> wrote:
> Signed-off-by: Raul Hidalgo Caballero <deinok at deinok.com>
> ---
> DEVELOPERS | 5 ++++
> package/Config.in.host | 1 +
> package/dotnet-sdk/dotnet-sdk.hash | 3 ++
> package/dotnet-sdk/dotnet-sdk.mk | 20 +++++++++++++
> package/dotnet/Config.in.host | 15 ++++++++++
Why is this Config.in.host in package/dotnet/ and not
package/dotnet-sdk/ ?
> diff --git a/package/dotnet-sdk/dotnet-sdk.hash
> b/package/dotnet-sdk/dotnet-sdk.hash
> new file mode 100644
> index 0000000000..a3016b2e49
> --- /dev/null
> +++ b/package/dotnet-sdk/dotnet-sdk.hash
> @@ -0,0 +1,3 @@
> +sha256 cfc21f5e8bd655ae997eec916138b707b1d290b83272c02a95c9f821b8c87310
> LICENSE.txt
> +sha256 01564961f8ca9744d0ecc5d3e72d7c1659df95898f3a077fd9140fd4023f3579
> ThirdPartyNotices.txt
> +sha256 23df1eca7eb1302dfb10f4edce7edf7150e57698576f61b2dcb777c833cbd80c
> dotnet-sdk-5.0.101-linux-x64.tar.gz
Note: your patch is line-wrapped. Could you use "git send-email" to
send it ?
> diff --git a/package/dotnet/Config.in.host b/package/dotnet/Config.in.host
> new file mode 100644
> index 0000000000..90b477a6a1
> --- /dev/null
> +++ b/package/dotnet/Config.in.host
> @@ -0,0 +1,15 @@
> +config BR2_PACKAGE_HOST_DOTNET_ARCH_SUPPORTS
> + bool
> + default y if BR2_HOSTARCH = "x86_64"
> +
> +config BR2_PACKAGE_HOST_DOTNET_RID
> + string
> + default "linux-x64" if BR2_HOSTARCH = "x86_64"
> +
> +config BR2_PACKAGE_HOST_DOTNET_SDK
> + bool "host dotnet-sdk"
> + depends on BR2_PACKAGE_HOST_DOTNET_ARCH_SUPPORTS
> + help
> + Dotnet SDK
This is a bit short :-)
> +
> + https://dotnet.microsoft.com/
The indentation for the help text is one tab + two spaces. You can run
"make check-package" to find this kind of coding style details.
> +class TestDotnetSdkBase(infra.basetest.BRTest):
You don't need this "Base" class, since there's only one subclass using
it.
> +
> + config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \
> + """
> + BR2_TARGET_ROOTFS_CPIO=y
> + """
> +
> +class TestHostDotnetSdk(TestDotnetSdkBase):
Just make this class inherit from infra.basetest.BRTest directly.
> + config = TestDotnetSdkBase.config + \
> + """
> + BR2_PACKAGE_HOST_DOTNET_SDK=y
> + """
use:
config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \
"""
BR2_PACKAGE_HOST_DOTNET_SDK=y
BR2_TARGET_ROOTFS_CPIO=y
"""
> + def test_run(self):
> + env = os.environ.copy()
Why do we have to do this ? You don't tweak any environment variable.
> + hostdir = os.path.join(self.builddir, 'host')
> + dotnet = os.path.join(hostdir, 'usr', 'bin', 'dotnet')
> + cmd = [dotnet, '--version']
> + exit_code = subprocess.call(cmd, stdout=self.b.logfile,
> stderr=self.b.logfile, env=env)
> + self.assertEqual(exit_code, 0)
> --
> 2.25.1
Otherwise, looks good. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
More information about the buildroot
mailing list