[Buildroot] [PATCH v3 02/11] boot/mv-ddr-marvell: Bump to HEAD as of 20201207

[Sergey Matyukevich]

Hello Dick,

> > My apologies for the late feedback. This change breaks the
> > build for MacchiatoBin board. I guess it also breaks the
> > build for ClearFrog GT 8k board. The reason is straightforward: > both boards make use of Marvell ATF v18.12.x which is
> > compatible with mv-ddr-marvell release devel-18.12.x.
> > Your change bumps mv-ddr-marvell version, however the new
> > version is not compatible with older Marvell ATF release since
> > mv_ddr_topology_map structure has been changed.
> 
> I'm very sorry for breaking this! I thought I tested a build with the original MacchiatoBin defconfig, but clearly my testing was flawed!
> 
> > Could you please clarify the reason behind this change ? There
> > are no users for mv-ddr-marvell other than Marvell ATF that is
> > used only for MacchiatoBin and ClearFrog GT 8k boards. So on
> > the first glance it looks like this change has been introduced
> > as an accompanying update/cleanup during your work on adding
> > EDK2 firmware.
> 
> Bumping to a later version of mv-ddr-marvell was required in
> order to successfully built with mainline ATF, which in turn is
> required in order to build well with the latest release of EDK2.
> Based on my brief analysis, most of the patches in Marvell's ATF
> has made it upstream to ATF v2.4 (or earlier). So I thought the
> best and most secure approach would be to use mainline.

As I mentioned, so far there were just two users of mv-ddr-marvell:
defconfigs for MacchiatoBin and ClearFrog GT 8k. And both of them used
Marvell ATF. It looks like test_atf.py still uses Marvell ATF as well.
So could you please clarify this point ? Am I correct assuming that
you have some defconfigs that are not yet in mainline buildroot,
enabling both EDK2 and mv-ddr-marvell ?

> > If so, then I would suggest to revert this particular commit.
> > Let me know if you have any objections for this change.
> 
> May I propose that we "roll-forward" instead, and update all
> Marvell defconfigs to use mainline ATF instead? I believe this
> would add the most value for Buildroot users, having access to
> the latest and most stable fixes. What do you think?

I see that Baruch has already updated ClearFrog GT 8k to use mainline
ATF. So I will just do the same for MacchiatoBin. Though I guess there
might be some issues with PCIe support for MacchiatoBin board since
upstream ATF does not yet include Marvell PCIe drivers.

Regards,
Sergey