[Buildroot] [PATCH 1/1] package/openvpn: set OPENVPN_CPE_ID_VENDOR

Peter Korsgaard peter at korsgaard.com
Sat Jan 9 21:18:04 UTC 2021


>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at bootlin.com> writes:

 > On Sat, 09 Jan 2021 16:08:24 +0100
 > Peter Korsgaard <peter at korsgaard.com> wrote:

 >> > +OPENVPN_CPE_ID_VENDOR = $(OPENVPN_NAME)  
 >> 
 >> I am not sure why we do this obfuscation with the _NAME variable instead
 >> of just "openvpn" -  But ok, a bunch of other packages do so as well.

 > Yes, it was done like this in the original patch from Matt, and I kept
 > it as-is, but I also wasn't too sure about it. But since nobody
 > complained when I posted the patch, I applied it as-is.

 > I definitely wouldn't oppose to changing this to not use the
 > <pkg>_NAME variable, as it find this indirection to not be very useful.

Ok, good. It may make sense to default _CPE_ID_VENDOR to $($(PKG)_NAME),
which is perhaps where this comes from?

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list