[Buildroot] [PATCH 1/1] package/wqy-zenhei: new package

[Klaus Heinrich Kiwi]

Hi Thomas,

On 1/2/2021 2:42 PM, Thomas Petazzoni wrote:
> Hello Klaus,
> 
> Thanks for this contribution! I have applied your patch to master, with
> a number of changes. See below for details.

Thanks! Those look good and thank you for taking the time to write down
useful explanations about the changes!

>> +config BR2_PACKAGE_WQY_ZENHEI
>> +	bool "wqy-zenhei (Free Chinese-capable fonts)"
> 
> Changed to:
> 
> 	bool "wqy-zenhei (Free Chinese-capable fonts)"
> 
> Indeed for consistency reason, we try to only use the lower-case
> package name as the short prompt for packags.

I was puzzled by this comment so I looked at the commit and I think you
meant to say that you removed the "(Free Chinese-capable fonts)" from the bool.
That makes sense, thanks!

>> diff --git a/package/wqy-zenhei/wqy-zenhei.hash b/package/wqy-zenhei/wqy-zenhei.hash
>> new file mode 100644
>> index 0000000000..86ae38da4f
>> --- /dev/null
>> +++ b/package/wqy-zenhei/wqy-zenhei.hash
>> @@ -0,0 +1,3 @@
>> +# locally computed sha256 from:
>> +# https://downloads.sourceforge.net/project/wqy/wqy-zenhei/0.9.45%20%28Fighting-state%20RC1%29/wqy-zenhei-0.9.45.tar.gz
> 
> Indicating the URL from which the tarball is downloaded and then the
> hash calculated locally is not very useful. Also, SourceForge provides
> md5 and sha1 hashes, and the hash of the license file was missing. So,
> I've changed to:

I understand the md5 and sha1 hashes that I completely missed, but couldn't decode why the locally computed/calculated
sha256 is not useful.

> 
> +# from https://sourceforge.net/projects/wqy/files/wqy-zenhei/0.9.45%20%28Fighting-state%20RC1%29/
> +md5  4c6c3f4e902dd5ee0a121e8c41d040bd  wqy-zenhei-0.9.45.tar.gz
> +sha1  b86b65d3048ade868fcc89229cfac6baf80a3e54  wqy-zenhei-0.9.45.tar.gz
> +# locally calculated
> +sha256  e4b7e306475bf9427d1757578f0e4528930c84c44eaa3f167d4c42f110ee75d6  wqy-zenhei-0.9.45.tar.gz
> +sha256  871c2a85e6bbf7bec65043820b706a265ed95d4e58c577fbb2c9f60c39c26ca7  COPYING

> 
> Applied with those changes. Thanks!
> 
> Thomas
> 
Thanks again!

-- 
Klaus Heinrich Kiwi <klaus at linux.vnet.ibm.com>