[Buildroot] [PATCH-NEXT 2/4] package/linux-firmware.mk: get rid of temporary tarball for file installation

Peter Korsgaard peter at korsgaard.com
Sat Feb 13 09:47:01 UTC 2021


>>>>> "Yann" == Yann E MORIN <yann.morin.1998 at free.fr> writes:

 > Peter, All,
 > On 2021-02-12 22:37 +0100, Peter Korsgaard spake thusly:
 >> >>>>> "Yann" == Yann E MORIN <yann.morin.1998 at free.fr> writes:
 >> > Peter, All,
 >> > On 2021-02-12 19:40 +0100, Peter Korsgaard spake thusly:
 >> >> There is no specific reason to use a temporary file, we can just as well
 >> >> pipe the two tar invocations together, so do that instead.
 >> > Actually, there *is* a reason why an intermediate tarball is used, see
 >> > commit 21a283ffb0d (linux-firmware: fail build for missing file).
 >> Ok, so we need to stick a set -o pipefail before?

 > That wqe'd have to use set -o pipefail is ugly ;-)

 > I prefer if we could cleanup the install sequence, as I suggested and
 > proposed in another reply.

Well, having our temporary tarball in the build directory is also kind
of ugly, but ok - Fine by me.

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list