[Buildroot] [PATCHv2 7/7] package/sysrepo: remove explicit setting of CMAKE_BUILD_TYPE

Jan Kundrát jan.kundrat at cesnet.cz
Fri Feb 12 15:20:02 UTC 2021


On pátek 12. února 2021 14:54:50 CET, Thomas De Schampheleire wrote:
> From: Thomas De Schampheleire <thomas.de_schampheleire at nokia.com>
>
> sysrepo explicitly set CMAKE_BUILD_TYPE=Release, ignoring any possible
> value of BR2_ENABLE_DEBUG (previously) or BR2_ENABLE_RUNTIME_DEBUG (now).
>
> With the introduction of BR2_ENABLE_RUNTIME_DEBUG, this change should no
> longer be necessary. Users that do not wish to have additional runtime
> debugging just keep BR2_ENABLE_RUNTIME_DEBUG disabled (default value).
>
> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire at nokia.com>
> ---
> v2: Jan Kundrát:
> - explicitly set REPO_PATH, which is set to a host path in case of
>   CMAKE_BUILD_TYPE=Debug (see e.g.
>   https://github.com/sysrepo/sysrepo/blob/v1.4.104/CMakeLists.txt#L138-L144)

Reviewed-by: Jan Kundrát <jan.kundrat at cesnet.cz>

Jan


More information about the buildroot mailing list